You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/08/18 18:27:56 UTC

[GitHub] [samza] prateekm commented on a change in pull request #1418: SAMZA-2583: Fix NPE in update SamzaHistogram Gauge values

prateekm commented on a change in pull request #1418:
URL: https://github.com/apache/samza/pull/1418#discussion_r472397514



##########
File path: samza-api/src/main/java/org/apache/samza/metrics/SamzaHistogram.java
##########
@@ -81,6 +81,10 @@ public void visit(MetricsVisitor visitor) {
      * and do not have MetricsReporter to update the values.
      */
     public Double getValue() {
+      if (gauges == null) {

Review comment:
       Please add an inline comment for when this can happen.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org