You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Dragan Sahpaski (Created) (JIRA)" <ji...@apache.org> on 2012/03/29 18:32:27 UTC
[jira] [Created] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
PlaceholderBlock should implement RenderCommand
-----------------------------------------------
Key: TAP5-1890
URL: https://issues.apache.org/jira/browse/TAP5-1890
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.3.2, 5.4
Reporter: Dragan Sahpaski
Priority: Trivial
If we have an empty zone like this:
<t:zone t:id="myZone" />
zone.getBody() fails to update the zone in an event handler with the following exception:
org.apache.tapestry5.ioc.util.UnknownValueException
A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
A patch is provided with a test that fails.
I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
Cheers,
Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Updated] (TAP5-1890) PlaceholderBlock should implement RenderCommand
Posted by Dragan Sahpaski <dr...@gmail.com>.
Hi,
I promised myself the third time I found this annoying I would make this
patch.
So I would be grateful if someone applied it to the 5.3 and 5.4 branch.
I opened a JIRA without consulting the list, but because I considered this
trivial and straitforward I trusted my judgement and went ahead.
Cheers,
Dragan Sahpaski
On Thu, Mar 29, 2012 at 6:42 PM, Dragan Sahpaski (Updated) (JIRA) <
jira@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Dragan Sahpaski updated TAP5-1890:
> ----------------------------------
>
> Attachment: TAP-1890.patch
>
> > PlaceholderBlock should implement RenderCommand
> > -----------------------------------------------
> >
> > Key: TAP5-1890
> > URL: https://issues.apache.org/jira/browse/TAP5-1890
> > Project: Tapestry 5
> > Issue Type: Bug
> > Components: tapestry-core
> > Affects Versions: 5.3.2, 5.4
> > Reporter: Dragan Sahpaski
> > Priority: Trivial
> > Labels: block, zone
> > Attachments: TAP-1890.patch
> >
> >
> > If we have an empty zone like this:
> > <t:zone t:id="myZone" />
> > zone.getBody() fails to update the zone in an event handler with the
> following exception:
> > org.apache.tapestry5.ioc.util.UnknownValueException
> > A component event handler method returned the value <PlaceholderBlock>.
> Return type
> org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock
> can not be handled.
> > This is because ComponentPageElementImpl.PlaceholderBlock does not
> implement RenderCommand.
> > A patch is provided with a test that fails.
> > I would highly appreciate it if a commiter applies it to the 5.4. branch
> and to the 5.3. branch.
> > Cheers,
> > Dragan Sahpaski
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
[jira] [Updated] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Dragan Sahpaski (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dragan Sahpaski updated TAP5-1890:
----------------------------------
Attachment: TAP-1890.patch
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Priority: Trivial
> Labels: block, zone
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Dragan Sahpaski (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dragan Sahpaski updated TAP5-1890:
----------------------------------
Attachment: TAP-1890.patch
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Priority: Trivial
> Labels: block, zone
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Dragan Sahpaski (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dragan Sahpaski updated TAP5-1890:
----------------------------------
Attachment: (was: TAP-1890.patch)
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Priority: Trivial
> Labels: block, zone
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Dragan Sahpaski (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dragan Sahpaski updated TAP5-1890:
----------------------------------
Attachment: TAP-1890.patch
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Priority: Trivial
> Labels: block, zone
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Dragan Sahpaski (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241569#comment-13241569 ]
Dragan Sahpaski commented on TAP5-1890:
---------------------------------------
No it's ok.
I haven't heard anyone else complaining. It's just going to be annoying when I notice it again but more than one workaround are possible.
Thanks.
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Assignee: Kalle Korhonen
> Priority: Trivial
> Labels: block, zone
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Kalle Korhonen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241525#comment-13241525 ]
Kalle Korhonen commented on TAP5-1890:
--------------------------------------
Applied to 5.4 trunk. While trivial to apply to 5.3.x branch, not sure if it's critical enough. Any justifications?
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Assignee: Kalle Korhonen
> Priority: Trivial
> Labels: block, zone
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Kalle Korhonen (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kalle Korhonen resolved TAP5-1890.
----------------------------------
Resolution: Fixed
Fix Version/s: 5.4
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Assignee: Kalle Korhonen
> Priority: Trivial
> Labels: block, zone
> Fix For: 5.4
>
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Kalle Korhonen (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kalle Korhonen resolved TAP5-1890.
----------------------------------
Resolution: Fixed
Fix Version/s: 5.4
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Assignee: Kalle Korhonen
> Priority: Trivial
> Labels: block, zone
> Fix For: 5.4
>
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Kalle Korhonen (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kalle Korhonen reassigned TAP5-1890:
------------------------------------
Assignee: Kalle Korhonen
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Assignee: Kalle Korhonen
> Priority: Trivial
> Labels: block, zone
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Kalle Korhonen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241525#comment-13241525 ]
Kalle Korhonen commented on TAP5-1890:
--------------------------------------
Applied to 5.4 trunk. While trivial to apply to 5.3.x branch, not sure if it's critical enough. Any justifications?
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Assignee: Kalle Korhonen
> Priority: Trivial
> Labels: block, zone
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Kalle Korhonen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241820#comment-13241820 ]
Kalle Korhonen commented on TAP5-1890:
--------------------------------------
Right, that's what I figured. Had there not been any workarounds available, I would have been more inclined to apply to 5.3 as well. Resolving.
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Assignee: Kalle Korhonen
> Priority: Trivial
> Labels: block, zone
> Fix For: 5.4
>
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Kalle Korhonen (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kalle Korhonen reassigned TAP5-1890:
------------------------------------
Assignee: Kalle Korhonen
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Assignee: Kalle Korhonen
> Priority: Trivial
> Labels: block, zone
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Dragan Sahpaski (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dragan Sahpaski updated TAP5-1890:
----------------------------------
Attachment: TAP-1890.patch
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Priority: Trivial
> Labels: block, zone
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241568#comment-13241568 ]
Hudson commented on TAP5-1890:
------------------------------
Integrated in tapestry-trunk-freestyle #694 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/694/])
RESOLVED - TAP5-1890: PlaceholderBlock should implement RenderCommand
- apply Dragan Sahpaski's patch, including tests, without changes (Revision 1307062)
Result = SUCCESS
kaosko : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307062
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/structure/ComponentPageElementImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/nested/ZoneDemo.tml
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/nested/ZoneDemo.java
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Assignee: Kalle Korhonen
> Priority: Trivial
> Labels: block, zone
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Dragan Sahpaski (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dragan Sahpaski updated TAP5-1890:
----------------------------------
Attachment: (was: TAP-1890.patch)
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Priority: Trivial
> Labels: block, zone
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Dragan Sahpaski (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241569#comment-13241569 ]
Dragan Sahpaski commented on TAP5-1890:
---------------------------------------
No it's ok.
I haven't heard anyone else complaining. It's just going to be annoying when I notice it again but more than one workaround are possible.
Thanks.
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Assignee: Kalle Korhonen
> Priority: Trivial
> Labels: block, zone
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241568#comment-13241568 ]
Hudson commented on TAP5-1890:
------------------------------
Integrated in tapestry-trunk-freestyle #694 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/694/])
RESOLVED - TAP5-1890: PlaceholderBlock should implement RenderCommand
- apply Dragan Sahpaski's patch, including tests, without changes (Revision 1307062)
Result = SUCCESS
kaosko : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307062
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/structure/ComponentPageElementImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/nested/ZoneDemo.tml
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/nested/ZoneDemo.java
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Assignee: Kalle Korhonen
> Priority: Trivial
> Labels: block, zone
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1890) PlaceholderBlock should implement
RenderCommand
Posted by "Kalle Korhonen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241820#comment-13241820 ]
Kalle Korhonen commented on TAP5-1890:
--------------------------------------
Right, that's what I figured. Had there not been any workarounds available, I would have been more inclined to apply to 5.3 as well. Resolving.
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
> Key: TAP5-1890
> URL: https://issues.apache.org/jira/browse/TAP5-1890
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2, 5.4
> Reporter: Dragan Sahpaski
> Assignee: Kalle Korhonen
> Priority: Trivial
> Labels: block, zone
> Fix For: 5.4
>
> Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira