You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/03/16 22:44:04 UTC
[GitHub] [couchdb] rnewson opened a new pull request #2672: View is
partitioned if db and view are partitioned
rnewson opened a new pull request #2672: View is partitioned if db and view are partitioned
URL: https://github.com/apache/couchdb/pull/2672
## Overview
We've seen a crash if DbPartitioned is false and ViewPartitioned is
true, which is obviously nonsense. The effect of the `nocase` is the
termination of the couch_index_server gen_server, which is a serious
amplification of a small (user-initiated) oddity.
## Testing recommendations
Difficult to induce. The protection that prevents us creating a ddoc with partitioned:true if the
db is partitioned:false must have a gap (perhaps ?new_edits=false / replicator path?)
## Related Issues or Pull Requests
N/A
## Checklist
- [x] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] rnewson commented on issue #2672: View is partitioned if
db and view are partitioned
Posted by GitBox <gi...@apache.org>.
rnewson commented on issue #2672: View is partitioned if db and view are partitioned
URL: https://github.com/apache/couchdb/pull/2672#issuecomment-599794129
pretty sure that's it. node was in mm, so did not participate in the fabric rpc call that created the shard with the partitioned setting. data was then added to the db and mem3 internal replication pushed to the mm'ed node. That does a create_if_missing without setting the partitioned flag.
Oops.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] rnewson commented on issue #2672: View is partitioned if
db and view are partitioned
Posted by GitBox <gi...@apache.org>.
rnewson commented on issue #2672: View is partitioned if db and view are partitioned
URL: https://github.com/apache/couchdb/pull/2672#issuecomment-599796803
(This PR must not be merged until a fix for the root cause is added to it, presumably in mem3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] wohali commented on issue #2672: View is partitioned if
db and view are partitioned
Posted by GitBox <gi...@apache.org>.
wohali commented on issue #2672: View is partitioned if db and view are partitioned
URL: https://github.com/apache/couchdb/pull/2672#issuecomment-604586959
Shouldn't this and #2690 target the `3.x` branch, from which our next release will be cut?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] rnewson commented on issue #2672: View is partitioned if
db and view are partitioned
Posted by GitBox <gi...@apache.org>.
rnewson commented on issue #2672: View is partitioned if db and view are partitioned
URL: https://github.com/apache/couchdb/pull/2672#issuecomment-599794472
(this PR will not fix the root cause just identified, it only prevents couch_index_server crashing when it does).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] rnewson commented on issue #2672: View is partitioned if
db and view are partitioned
Posted by GitBox <gi...@apache.org>.
rnewson commented on issue #2672: View is partitioned if db and view are partitioned
URL: https://github.com/apache/couchdb/pull/2672#issuecomment-599793367
A more plausible path is that the shard was created by a create_if_missing call that did not set the partitioned:true property. So db creation was fine, but this db was in maintenance mode, and so got its .couch file via mem3 internals.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] chewbranca commented on issue #2672: View is partitioned
if db and view are partitioned
Posted by GitBox <gi...@apache.org>.
chewbranca commented on issue #2672: View is partitioned if db and view are partitioned
URL: https://github.com/apache/couchdb/pull/2672#issuecomment-601958541
Here's a WIP PR for addressing the underlying db creation issues: https://github.com/apache/couchdb/pull/2690
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] davisp commented on issue #2672: View is partitioned if
db and view are partitioned
Posted by GitBox <gi...@apache.org>.
davisp commented on issue #2672: View is partitioned if db and view are partitioned
URL: https://github.com/apache/couchdb/pull/2672#issuecomment-600092515
For the underlying bit, get_or_create should probably check the dbs db for creation options. If its not got the doc replicated yet then freak out and not create anything etc etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services