You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by cc...@apache.org on 2019/12/18 01:55:23 UTC
[mynewt-newt] branch master updated (c52fc7c -> 3330958)
This is an automated email from the ASF dual-hosted git repository.
ccollins pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git.
from c52fc7c resolve: Only print valid YCfg parse warnings
new 8badcf5 Don't warn if `version.yml` file is not present
new 3330958 Include repo name in compat map warning
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
newt/install/install.go | 2 +-
newt/repo/repo.go | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[mynewt-newt] 02/02: Include repo name in compat map warning
Posted by cc...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ccollins pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git
commit 33309584c5d00547f9809323a765358c5dcb9abc
Author: Christopher Collins <cc...@apache.org>
AuthorDate: Tue Dec 17 16:49:38 2019 -0800
Include repo name in compat map warning
If a repo's current version is missing from its compatibility map, newt
produces the following warning:
WARNING: Repo version missing from compatibility map
This commit adds the name of the culprit repo to the message.
---
newt/repo/repo.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/newt/repo/repo.go b/newt/repo/repo.go
index 4f13a7c..6aedd56 100644
--- a/newt/repo/repo.go
+++ b/newt/repo/repo.go
@@ -539,7 +539,7 @@ func (r *Repo) CheckNewtCompatibility(
if !ok {
// Unknown repo version.
return compat.NEWT_COMPAT_WARN,
- "Repo version missing from compatibility map"
+ r.Name() + ": Repo version missing from compatibility map"
}
code, text := tbl.CheckNewtVer(nvers)
[mynewt-newt] 01/02: Don't warn if `version.yml` file is not present
Posted by cc...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ccollins pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git
commit 8badcf53ce95c90bfec38d5cf2c6af84b4493bfe
Author: Christopher Collins <cc...@apache.org>
AuthorDate: Tue Dec 17 16:48:01 2019 -0800
Don't warn if `version.yml` file is not present
A repo can optionally contain a `version.yml` file to allow its
version number to be inferred at a particular commit. If this file was
missing, newt would print the following warning:
Could not detect version of installed repo \"%s\"; assuming %s
This commit reduces the severity level of this message from warn to
info.
---
newt/install/install.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/newt/install/install.go b/newt/install/install.go
index dd2909f..7ce2792 100644
--- a/newt/install/install.go
+++ b/newt/install/install.go
@@ -146,7 +146,7 @@ func detectVersion(r *repo.Repo) (newtutil.RepoVersion, error) {
Commit: commit,
}
- util.OneTimeWarning(
+ log.Infof(
"Could not detect version of installed repo \"%s\"; assuming %s",
r.Name(), ver.String())
}