You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/07 22:32:46 UTC

[GitHub] [incubator-nuttx] v01d opened a new pull request #3477: Replace wrong inclusion of sys/errno.h (toolchain provided) with errno.h

v01d opened a new pull request #3477:
URL: https://github.com/apache/incubator-nuttx/pull/3477


   ## Summary
   
   Found many files including `sys/errno.h` which is actually provided by system. The correct path should be just `errno.h`
   which is provided by NuttX.
   
   ## Impact
   
   Probably nothing was broken, as only very basic standard definitions where used from that file.
   
   ## Testing
   
   Build esp32 configs successfully, others should behave the same
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on pull request #3477: Replace wrong inclusion of sys/errno.h (toolchain provided) with errno.h

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3477:
URL: https://github.com/apache/incubator-nuttx/pull/3477#issuecomment-815308134


   Check fails due to mixed case of external symbol


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3477: Replace wrong inclusion of sys/errno.h (toolchain provided) with errno.h

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3477:
URL: https://github.com/apache/incubator-nuttx/pull/3477


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on pull request #3477: Replace wrong inclusion of sys/errno.h (toolchain provided) with errno.h

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3477:
URL: https://github.com/apache/incubator-nuttx/pull/3477#issuecomment-815305766


   It seems the `sys/errno.h` file on my computer just does `#include <errno.h>` so this was probably benign anyway. But since NuttX does not currently provide a `sys/errno.h`, better be safe than sorry.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org