You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Jeff-Lv (GitHub)" <gi...@apache.org> on 2018/10/25 12:55:41 UTC

[GitHub] [incubator-dubbo] Jeff-Lv opened pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

## What is the purpose of the change

The class StaticContext is a Map which place anything to it and it will leave design risks if StaticContext is used easily and everywhere.

## Verifying this change

remove the class StaticContext
fix the testcases
refactor the part of using StaticContext which is mainly about Async

F

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] kimmking commented on pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "kimmking (GitHub)" <gi...@apache.org>.
{}


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 commented on pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
I think the original value is more reasonable since it's used in URL.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 commented on pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
consider to use `{...}`

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 commented on pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
pls. consider to use `{...}`.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] Jeff-Lv commented on issue #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "Jeff-Lv (GitHub)" <gi...@apache.org>.
I just commits the changes according to @beiwei30  @kimmking advices. 

1） revert the Constants value changes. I used to use the values of async contants to map the properties of AsyncMethodInfo which is not allowed to the xxx.xxx and it was OK formerly when it is used as the key of StaticContext's map. So I changes those  values. But the finally refactor is no more need those references.

2)  fix the types and format {}

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] Jeff-Lv commented on issue #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "Jeff-Lv (GitHub)" <gi...@apache.org>.
I just commits the changes according to @beiwei30  @kimmking advices. 
1） revert the Constants value changes. I used to use the values of async contants to map the properties of AsyncMethodInfo which is not allowed to the xxx.xxx and it was OK formerly when it is used as the key of StaticContext's map. So I changes those  values. But the finally refactor is no more need those references.

2) fix the types and format {}

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] Jeff-Lv commented on pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "Jeff-Lv (GitHub)" <gi...@apache.org>.
yeh, this hint is good. 

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=h1) Report
> Merging [#2688](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/7286e23bb68cc8826f84eebd23d76717a2aaeea5?src=pr&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `77.41%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #2688      +/-   ##
==========================================
- Coverage   63.24%   63.13%   -0.12%     
==========================================
  Files         573      572       -1     
  Lines       25763    25791      +28     
  Branches     4533     4540       +7     
==========================================
- Hits        16294    16282      -12     
- Misses       7320     7353      +33     
- Partials     2149     2156       +7
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/dubbo/rpc/model/ApplicationModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9BcHBsaWNhdGlvbk1vZGVsLmphdmE=) | `92.85% <ø> (+7.14%)` | :arrow_up: |
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `88.88% <ø> (ø)` | :arrow_up: |
| [...java/org/apache/dubbo/rpc/model/ProviderModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9Qcm92aWRlck1vZGVsLmphdmE=) | `52.94% <ø> (ø)` | :arrow_up: |
| [...java/org/apache/dubbo/rpc/model/ConsumerModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9Db25zdW1lck1vZGVsLmphdmE=) | `64.28% <100%> (+5.95%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/model/ConsumerMethodModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9Db25zdW1lck1ldGhvZE1vZGVsLmphdmE=) | `81.39% <100%> (+21.39%)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `73.68% <73.68%> (-3.11%)` | :arrow_down: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `56.27% <87.5%> (+0.79%)` | :arrow_up: |
| [.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL2ZpbHRlci9GdXR1cmVGaWx0ZXIuamF2YQ==) | `64.42% <95.65%> (+5.33%)` | :arrow_up: |
| [...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWNjZXNzTG9nRmlsdGVyLmphdmE=) | `52.22% <0%> (-18.89%)` | :arrow_down: |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=footer). Last update [7286e23...5a69aa0](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 commented on pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
pls. use `{...}`

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] Jeff-Lv commented on pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "Jeff-Lv (GitHub)" <gi...@apache.org>.
Actually, those constants value is not references any more. Formerly, it was used for the mapping between annatation of parameter and the key of Map. Now, this mapping is no need any more.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] Jeff-Lv commented on pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "Jeff-Lv (GitHub)" <gi...@apache.org>.
```
appendAttributes(attributes, method, prefix + "." + method.getName());
checkAndConvertImplicitConfig(method, map, attributes);
```
Those above methods is only for the storing async attributes to StaticContext.


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=h1) Report
> Merging [#2688](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/7286e23bb68cc8826f84eebd23d76717a2aaeea5?src=pr&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `77.41%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #2688      +/-   ##
==========================================
- Coverage   63.24%   63.13%   -0.12%     
==========================================
  Files         573      572       -1     
  Lines       25763    25791      +28     
  Branches     4533     4540       +7     
==========================================
- Hits        16294    16282      -12     
- Misses       7320     7354      +34     
- Partials     2149     2155       +6
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/dubbo/rpc/model/ApplicationModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9BcHBsaWNhdGlvbk1vZGVsLmphdmE=) | `92.85% <ø> (+7.14%)` | :arrow_up: |
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `88.88% <ø> (ø)` | :arrow_up: |
| [...java/org/apache/dubbo/rpc/model/ProviderModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9Qcm92aWRlck1vZGVsLmphdmE=) | `52.94% <ø> (ø)` | :arrow_up: |
| [...java/org/apache/dubbo/rpc/model/ConsumerModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9Db25zdW1lck1vZGVsLmphdmE=) | `64.28% <100%> (+5.95%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/model/ConsumerMethodModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9Db25zdW1lck1ldGhvZE1vZGVsLmphdmE=) | `81.39% <100%> (+21.39%)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `73.68% <73.68%> (-3.11%)` | :arrow_down: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `56.27% <87.5%> (+0.79%)` | :arrow_up: |
| [.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL2ZpbHRlci9GdXR1cmVGaWx0ZXIuamF2YQ==) | `64.42% <95.65%> (+5.33%)` | :arrow_up: |
| [...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWNjZXNzTG9nRmlsdGVyLmphdmE=) | `52.22% <0%> (-18.89%)` | :arrow_down: |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=footer). Last update [7286e23...a2d5d3a](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj commented on pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "chickenlj (GitHub)" <gi...@apache.org>.
agree with beiwei30

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 commented on pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
IDE hint: 

```java
return consumerMethodModelEntry.map(Map.Entry::getValue).orElse(null);
```

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=h1) Report
> Merging [#2688](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/7286e23bb68cc8826f84eebd23d76717a2aaeea5?src=pr&el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `77.59%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #2688      +/-   ##
==========================================
+ Coverage   63.24%   63.35%   +0.11%     
==========================================
  Files         573      578       +5     
  Lines       25763    25963     +200     
  Branches     4533     4547      +14     
==========================================
+ Hits        16294    16450     +156     
- Misses       7320     7352      +32     
- Partials     2149     2161      +12
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/dubbo/rpc/model/ApplicationModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9BcHBsaWNhdGlvbk1vZGVsLmphdmE=) | `92.85% <ø> (+7.14%)` | :arrow_up: |
| [...java/org/apache/dubbo/rpc/model/ProviderModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9Qcm92aWRlck1vZGVsLmphdmE=) | `52.94% <ø> (ø)` | :arrow_up: |
| [...java/org/apache/dubbo/rpc/model/ConsumerModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9Db25zdW1lck1vZGVsLmphdmE=) | `64.28% <100%> (+5.95%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/model/ConsumerMethodModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9Db25zdW1lck1ldGhvZE1vZGVsLmphdmE=) | `81.39% <100%> (+21.39%)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `73.68% <73.68%> (-3.11%)` | :arrow_down: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `56.27% <87.5%> (+0.79%)` | :arrow_up: |
| [.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL2ZpbHRlci9GdXR1cmVGaWx0ZXIuamF2YQ==) | `65.42% <96.15%> (+6.32%)` | :arrow_up: |
| [...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWNjZXNzTG9nRmlsdGVyLmphdmE=) | `52.22% <0%> (-18.89%)` | :arrow_down: |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `75.86% <0%> (-10.35%)` | :arrow_down: |
| [...rpc/cluster/loadbalance/RoundRobinLoadBalance.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvUm91bmRSb2JpbkxvYWRCYWxhbmNlLmphdmE=) | `85.29% <0%> (-8.46%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2688/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=footer). Last update [7286e23...4cba125](https://codecov.io/gh/apache/incubator-dubbo/pull/2688?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 commented on pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
`setted` is typo

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 commented on pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
unused imports.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] Jeff-Lv commented on issue #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "Jeff-Lv (GitHub)" <gi...@apache.org>.
I just commits the changes according to @beiwei30  @kimmking advices. 

1) revert the Constants value changes. I used to use the values of async contants to map the properties of AsyncMethodInfo which is not allowed to the xxx.xxx and it was OK formerly when it is used as the key of StaticContext's map. So I changes those  values. But the finally refactor is no more need those references.

2)  fix the types and format {}

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 commented on pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
why remove `appendAttributes(attributes, method, prefix + "." + method.getName());`

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 closed pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] kimmking commented on pull request #2688: [version 2.7.0]remove the StaticContext class and refactor the code related to Async

Posted by "kimmking (GitHub)" <gi...@apache.org>.
why rename?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2688 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org