You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/04 18:47:36 UTC

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3925: Add cache mode param properly

GabrielBrascher commented on a change in pull request #3925: Add cache mode param properly
URL: https://github.com/apache/cloudstack/pull/3925#discussion_r387778031
 
 

 ##########
 File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
 ##########
 @@ -178,6 +178,13 @@
             since = "4.4")
     private Integer hypervisorSnapshotReserve;
 
+    @Parameter(name = ApiConstants.CACHE_MODE,
+            type = CommandType.STRING,
+            required = false,
+            description = "the cache mode to use for this disk offering. none, writeback or writethrough",
+            since = "4.13")
 
 Review comment:
   `since = "4.14"` if merged in time for 4.14 releasing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services