You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/28 15:00:40 UTC
[GitHub] [incubator-devlake] Startrekzky opened a new issue, #3237: [Bug][config-ui] Clicking `save and run now` doesn't refresh the blueprint page and show the in-progress run
Startrekzky opened a new issue, #3237:
URL: https://github.com/apache/incubator-devlake/issues/3237
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
### What happened
After I finished configuring a blueprint and clicked the `save and run now`, the page looked like this:
I thought `save and run now` was broken, so I clicked 3 times again. Then I refreshed the page, and it showed a current run and 3 historical runs:
I'm not sure if these 4 pipelines executed concurrently will slow down the collection speed, if so, this bug can be very problematic.
### What you expected to happen
This page auto-refresh and show the current run.
### How to reproduce
Visit here or your own config-ui and create a blueprint: https://ui-my-svr02.demo.devlake.io/
### Anything else
_No response_
### Version
main
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #3237: [Bug][config-ui] Clicking `save and run now` doesn't refresh the blueprint page and show the in-progress run
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #3237:
URL: https://github.com/apache/incubator-devlake/issues/3237#issuecomment-1261129641
> @likyh I don't think there's anything refactoring needed at this point, what exact bugs do you mean by "several bugs" ?
Let's look at the bugs one by one.
1. ~the `setInterval` will never stop. (fixed before)~
2. When open this page, the delicate request `pipelines/17` and `pipelines/17/tasks` are sent at once.
3. the request `/api/plugins/gitlab/connection/1` is sent when try to edit jira connection. There are no gitlab connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #3237: [Bug][config-ui] Clicking `save and run now` doesn't refresh the blueprint page and show the in-progress run
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #3237:
URL: https://github.com/apache/incubator-devlake/issues/3237#issuecomment-1261100309
> @likyh That last screenshot where "gitlab" is in the connections is most likely due to all connections being fetched, this is not a bug.
@e2corporation Snapshot 2 show that there is only one plugin. It's because the default value and the page just use connection from /connections instead of /connection/:id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation closed issue #3237: [Bug][config-ui] Clicking `save and run now` doesn't refresh the blueprint page and show the in-progress run
Posted by GitBox <gi...@apache.org>.
e2corporation closed issue #3237: [Bug][config-ui] Clicking `save and run now` doesn't refresh the blueprint page and show the in-progress run
URL: https://github.com/apache/incubator-devlake/issues/3237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #3237: [Bug][config-ui] Clicking `save and run now` doesn't refresh the blueprint page and show the in-progress run
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #3237:
URL: https://github.com/apache/incubator-devlake/issues/3237#issuecomment-1263111197
Another 2 bugs found in this page:
1. https://github.com/apache/incubator-devlake/pull/3287#pullrequestreview-1126231661
2. https://github.com/apache/incubator-devlake/pull/3287#issuecomment-1263105695
@e2corporation I think this page needs to be refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3237: [Bug][config-ui] Clicking `save and run now` doesn't refresh the blueprint page and show the in-progress run
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3237:
URL: https://github.com/apache/incubator-devlake/issues/3237#issuecomment-1261099090
@likyh I don't think there's anything refactoring needed at this point, what exact bugs do you mean by "several bugs" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3237: [Bug][config-ui] Clicking `save and run now` doesn't refresh the blueprint page and show the in-progress run
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3237:
URL: https://github.com/apache/incubator-devlake/issues/3237#issuecomment-1263462162
> Another 2 bugs found in this page:
>
> 1. [[Bug][config-ui] board transfomation match wrong when edit jira blueprint #3294](https://github.com/apache/incubator-devlake/issues/3294)
> 2. [[Bug][config-ui] add board but type mapping is wrong when edit jira blueprint #3295](https://github.com/apache/incubator-devlake/issues/3295)
>
> @e2corporation I think this page needs to be refactored.
@likyh This should have been fixed with my last PR for "JIRA Modification Degraded..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3237: [Bug][config-ui] Clicking `save and run now` doesn't refresh the blueprint page and show the in-progress run
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3237:
URL: https://github.com/apache/incubator-devlake/issues/3237#issuecomment-1261096520
@likyh That last screenshot where "gitlab" is in the connections is most likely due to all connections being fetched, this is not a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Startrekzky commented on issue #3237: [Bug][config-ui] Clicking `save and run now` doesn't refresh the blueprint page and show the in-progress run
Posted by GitBox <gi...@apache.org>.
Startrekzky commented on issue #3237:
URL: https://github.com/apache/incubator-devlake/issues/3237#issuecomment-1263352483
Verified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #3237: [Bug][config-ui] Clicking `save and run now` doesn't refresh the blueprint page and show the in-progress run
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #3237:
URL: https://github.com/apache/incubator-devlake/issues/3237#issuecomment-1261094051
@e2corporation Are you focused on this issue? If not, would like to allow me to fix this issue and refactor some code on this page? You know, this page has several bugs caused by code. Such as setInteval will not finish when pipeline is success; send the same request at the same times; send no use request when edit blueprint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3237: [Bug][config-ui] Clicking `save and run now` doesn't refresh the blueprint page and show the in-progress run
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3237:
URL: https://github.com/apache/incubator-devlake/issues/3237#issuecomment-1261114861
@likyh If you'd like to do some tasteful refactoring and feel that there are valid issues to address on Blueprint Detail then proceed, keep in mind we are frozen for a release so too much refactoring may introduce new bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3237: [Bug][config-ui] Clicking `save and run now` doesn't refresh the blueprint page and show the in-progress run
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3237:
URL: https://github.com/apache/incubator-devlake/issues/3237#issuecomment-1261142352
> > @likyh I don't think there's anything refactoring needed at this point, what exact bugs do you mean by "several bugs" ?
>
> Let's look at the bugs one by one.
>
> 1. ~the `setInterval` will never stop. (fixed before)~
> 2. When open this page, the delicate request `pipelines/17` and `pipelines/17/tasks` are sent at once.
> 
Yes this is desired behavior, tasks are not bundled with the pipeline details, we associate the related tasks to the pipeline object after fetching related tasks.
> 3. the request `/api/plugins/gitlab/connection/1` is sent when try to edit jira connection. There are no gitlab connection.
> 
There isn't a gitlab connection here yes on the blueprint, but at a higher level we need to be aware of all connections available (DSM Hook builds the all connections list). So what you are seeing is the effect of All connections being fetched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org