You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by GitBox <gi...@apache.org> on 2021/10/07 12:51:32 UTC

[GitHub] [poi] komarovd95 opened a new pull request #260: Check XDGFCell value for null to avoid NullPointerException

komarovd95 opened a new pull request #260:
URL: https://github.com/apache/poi/pull/260


   I've discovered that some VSDX documents skip the value cell attribute ('V'). It makes unable to open such documents because NullPointerException is always thrown for some predefined cells (see `XDGFShape#readProperties` method). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[GitHub] [poi] pjfanning commented on pull request #260: Check XDGFCell value for null to avoid NullPointerException

Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #260:
URL: https://github.com/apache/poi/pull/260#issuecomment-937834547


   @komarovd95 can you close this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[GitHub] [poi] komarovd95 commented on pull request #260: Check XDGFCell value for null to avoid NullPointerException

Posted by GitBox <gi...@apache.org>.
komarovd95 commented on pull request #260:
URL: https://github.com/apache/poi/pull/260#issuecomment-937817188


   [Activity diagram by role example.zip](https://github.com/apache/poi/files/7303864/Activity.diagram.by.role.example.zip)
   This file demonstrates it (some TxtWidth cells don't have 'V' attribute). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[GitHub] [poi] komarovd95 closed pull request #260: Check XDGFCell value for null to avoid NullPointerException

Posted by GitBox <gi...@apache.org>.
komarovd95 closed pull request #260:
URL: https://github.com/apache/poi/pull/260


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[GitHub] [poi] komarovd95 closed pull request #260: Check XDGFCell value for null to avoid NullPointerException

Posted by GitBox <gi...@apache.org>.
komarovd95 closed pull request #260:
URL: https://github.com/apache/poi/pull/260


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[GitHub] [poi] komarovd95 edited a comment on pull request #260: Check XDGFCell value for null to avoid NullPointerException

Posted by GitBox <gi...@apache.org>.
komarovd95 edited a comment on pull request #260:
URL: https://github.com/apache/poi/pull/260#issuecomment-937817188


   [Activity diagram by role example.zip](https://github.com/apache/poi/files/7303864/Activity.diagram.by.role.example.zip)
   This file demonstrates it (some TxtWidth cells don't have 'V' attribute). 
   
   GitHub doesn't allow VSDX files to be attached. So, just rename file to .vsdx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[GitHub] [poi] komarovd95 edited a comment on pull request #260: Check XDGFCell value for null to avoid NullPointerException

Posted by GitBox <gi...@apache.org>.
komarovd95 edited a comment on pull request #260:
URL: https://github.com/apache/poi/pull/260#issuecomment-937817188


   [Activity diagram by role example.zip](https://github.com/apache/poi/files/7303864/Activity.diagram.by.role.example.zip)
   This file demonstrates it (some TxtWidth cells don't have 'V' attribute). 
   
   GitHub doesn't allow VSDX files to be attached. So, just rename file to .vsdx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[GitHub] [poi] komarovd95 commented on pull request #260: Check XDGFCell value for null to avoid NullPointerException

Posted by GitBox <gi...@apache.org>.
komarovd95 commented on pull request #260:
URL: https://github.com/apache/poi/pull/260#issuecomment-937817188


   [Activity diagram by role example.zip](https://github.com/apache/poi/files/7303864/Activity.diagram.by.role.example.zip)
   This file demonstrates it (some TxtWidth cells don't have 'V' attribute). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[GitHub] [poi] pjfanning commented on pull request #260: Check XDGFCell value for null to avoid NullPointerException

Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #260:
URL: https://github.com/apache/poi/pull/260#issuecomment-937790276


   @komarovd95 can you provide a file that demos the issue? We appreciate all code submissions but we need test coverage to ensure the code changes don't end up with regression issues when future changes are made.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[GitHub] [poi] pjfanning commented on pull request #260: Check XDGFCell value for null to avoid NullPointerException

Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #260:
URL: https://github.com/apache/poi/pull/260#issuecomment-937790276






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[GitHub] [poi] pjfanning commented on pull request #260: Check XDGFCell value for null to avoid NullPointerException

Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #260:
URL: https://github.com/apache/poi/pull/260#issuecomment-937833956


   @komarovd95 thanks - this is merged - https://github.com/apache/poi/commit/36cf0e943e7a66f2f2fadd76bfd1c24a2d158c46, https://github.com/apache/poi/commit/4ec60ae99275697c1518015832e062d7d8220db7, https://github.com/apache/poi/commit/5562858ebafd781cb33ec010091a99a483c90cb1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org