You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/12 11:16:00 UTC

[jira] [Commented] (ARTEMIS-1803) MessageReference should include sessionId

    [ https://issues.apache.org/jira/browse/ARTEMIS-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435366#comment-16435366 ] 

ASF GitHub Bot commented on ARTEMIS-1803:
-----------------------------------------

GitHub user cshannon opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2012

    ARTEMIS-1803 - Add sessionId to MessageReference

    Track the sessionId along with the consumerId in a MessageReference when
    appropriate in order to figure out which consumer the reference belongs
    to

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1803

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2012.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2012
    
----
commit 262cac9f0b8b581b56bda6219bd43b7922edf6c9
Author: Christopher L. Shannon (cshannon) <ch...@...>
Date:   2018-04-12T11:05:16Z

    ARTEMIS-1803 - Add sessionId to MessageReference
    
    Track the sessionId along with the consumerId in a MessageReference when
    appropriate in order to figure out which consumer the reference belongs
    to

----


> MessageReference should include sessionId
> -----------------------------------------
>
>                 Key: ARTEMIS-1803
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1803
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.5.0
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Minor
>
> Right now a MessageReference will track a consumerId (in certain scenarios) but the sessionId is not included.  This is a problem because consumerIds are not unique and are duplicated across sessions.  In order to find a unique consumer you need the sessionId and consumerId as well. 
> A use case for when this is important is when writing custom plugins.  Some of the callbacks pass a message reference and it would be good to be able to figure out which consumer the reference belonged to such as in the messageAcknowledged callback.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)