You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by cramja <gi...@git.apache.org> on 2017/02/08 02:32:25 UTC
[GitHub] incubator-quickstep pull request #184: Refactor building.md
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/184
Refactor building.md
* Added table of content
* updated building instructions
* Removed some redundancy
* Moved bonus sections into the appendix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cramja/incubator-quickstep refactor-building
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #184
----
commit 8245819bfd773ac3a8b4d8733eb0056dc230e020
Author: cramja <ma...@gmail.com>
Date: 2017-02-08T00:41:16Z
Refactor building.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #184: Refactor building.md
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/184
changed and closed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #184: Refactor building.md
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/184#discussion_r100139845
--- Diff: BUILDING.md ---
@@ -1,60 +1,71 @@
-Quickstep Build Guide
-=====================
+# Quickstep Build Guide
+**Contents**
+* [Basic Instructions](#basic-instructions)
+ * [Prerequisites](#prerequisites)
+ * [Building](#building)
+ * [Running Quickstep](#running-quickstep)
+ * [Running Tests](#running-tests)
+ * [Configuring with CMake](#configuring-with-cmake)
+* [Advanced Configuration](#advanced-configuration)
+* [Appendix](#appendix)
+ * [Building on Windows](#building-on-windows)
+ * [Building in Vagrant](#building-in-vagrant)
-What You Will Need
-------------------
-To build quickstep, you will need a C++ compiler that supports the C++14
-standard (GCC 4.9 or Clang 3.4 or higher are known to work), and CMake. If you
-have GNU Bison and Flex as well, they will be used to build the parser and
-lexer sources (otherwise, preprocessed sources made with Bison and Flex will be
-used).
+**Short Version**
-### Vagrant
+```sh
+cd third_party
+./download_and_patch_prerequisites.sh
+cd ../build
+cmake ..
+make -j4 quickstep_cli_shell
--- End diff --
sure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #184: Refactor building.md
Posted by cramja <gi...@git.apache.org>.
Github user cramja closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #184: Refactor building.md
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/184
> The job exceeded the maximum time limit for jobs, and has been terminated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #184: Refactor building.md
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/184#discussion_r100128102
--- Diff: BUILDING.md ---
@@ -1,60 +1,71 @@
-Quickstep Build Guide
-=====================
+# Quickstep Build Guide
+**Contents**
+* [Basic Instructions](#basic-instructions)
+ * [Prerequisites](#prerequisites)
+ * [Building](#building)
+ * [Running Quickstep](#running-quickstep)
+ * [Running Tests](#running-tests)
+ * [Configuring with CMake](#configuring-with-cmake)
+* [Advanced Configuration](#advanced-configuration)
+* [Appendix](#appendix)
+ * [Building on Windows](#building-on-windows)
+ * [Building in Vagrant](#building-in-vagrant)
-What You Will Need
-------------------
-To build quickstep, you will need a C++ compiler that supports the C++14
-standard (GCC 4.9 or Clang 3.4 or higher are known to work), and CMake. If you
-have GNU Bison and Flex as well, they will be used to build the parser and
-lexer sources (otherwise, preprocessed sources made with Bison and Flex will be
-used).
+**Short Version**
-### Vagrant
+```sh
+cd third_party
+./download_and_patch_prerequisites.sh
+cd ../build
+cmake ..
+make -j4 quickstep_cli_shell
--- End diff --
I'd suggest to remove `-j4` here, as it does not apply to everyone, and we have mentioned the parallel build jobs later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---