[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3370: minor fix: clean data type for negative operation

[GitBox <gi...@apache.org>]

alamb commented on code in PR #3370:
URL: https://github.com/apache/arrow-datafusion/pull/3370#discussion_r963599176


##########
datafusion/physical-expr/src/expressions/negative.rs:
##########
@@ -118,13 +118,11 @@ pub fn negative(
     arg: Arc<dyn PhysicalExpr>,
     input_schema: &Schema,
 ) -> Result<Arc<dyn PhysicalExpr>> {
+    // TODO: the data type checker should be done in the logical plan phase

Review Comment:
   I am not sure if anyone creates physical Exprs directly without a logical_plan Expr. 
   
   However, I agree with this approach to throw an error if the physical types don't line up -- automatic coercion should be done at the logical level



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org