You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Thomas Mueller (JIRA)" <ji...@apache.org> on 2014/03/18 10:46:42 UTC
[jira] [Commented] (OAK-1554) Clarify behaviour for BlobStore api
for invalid arguments
[ https://issues.apache.org/jira/browse/OAK-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939011#comment-13939011 ]
Thomas Mueller commented on OAK-1554:
-------------------------------------
In this issue, I would just fix the build. Refactoring the tests is not urgent and can be done later, I opened OAK-1556 for this.
> Clarify behaviour for BlobStore api for invalid arguments
> ---------------------------------------------------------
>
> Key: OAK-1554
> URL: https://issues.apache.org/jira/browse/OAK-1554
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Chetan Mehrotra
> Priority: Minor
> Fix For: 0.20
>
>
> Currently testcase in AbstractBlobStore test has following check
> {code:java}
> @Test
> public void testEmptyIdentifier() throws Exception {
> byte[] data = new byte[1];
> assertEquals(-1, store.readBlob("", 0, data, 0, 1));
> assertEquals(0, store.getBlobLength(""));
> }
> {code}
> This fails for DataStore based BlobStore as the blodId are invalid.
> So need to clarify the behaviour around handling of invalid blobId. Should they return result or throw exception
--
This message was sent by Atlassian JIRA
(v6.2#6252)