You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2011/05/29 02:22:47 UTC
[jira] [Commented] (LUCENE-3152) MockDirectoryWrapper should wrap
the lockfactory
[ https://issues.apache.org/jira/browse/LUCENE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040705#comment-13040705 ]
Michael McCandless commented on LUCENE-3152:
--------------------------------------------
Patch looks great! Nice to have MDW catch un-released locks too :)
> MockDirectoryWrapper should wrap the lockfactory
> ------------------------------------------------
>
> Key: LUCENE-3152
> URL: https://issues.apache.org/jira/browse/LUCENE-3152
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Reporter: Robert Muir
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3152.patch
>
>
> After applying the patch from LUCENE-3147, I added a line to make the test fail if it cannot remove its temporary directory.
> I ran 'ant test' on linux 50 times, and it passed all 50 times.
> But on windows, it failed often because of write.lock... this is because of unclosed writers in the test.
> MockDirectoryWrapper is currently unaware of this write.lock, I think it should wrap the lockfactory so that .close() will fail if there are any outstanding locks.
> Then hopefully these tests would fail on linux too.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org