You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2020/03/03 07:01:05 UTC

[GitHub] [unomi] RonBarabash commented on a change in pull request #131: Add the ability to update event by item id

RonBarabash commented on a change in pull request #131: Add the ability to update event by item id
URL: https://github.com/apache/unomi/pull/131#discussion_r386829687
 
 

 ##########
 File path: wab/src/main/java/org/apache/unomi/web/ServletCommon.java
 ##########
 @@ -73,6 +73,9 @@ public static Changes handleEvents(List<Event> events, Session session, Profile
                         logger.warn("Event is not allowed : {}", event.getEventType());
                         continue;
                     }
+                    if (event.getItemId() != null) {
 
 Review comment:
   hey @sergehuber,
   I understand, i added your suggestion to the pr,
   10x
   Ron

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services