You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2008/06/24 13:22:44 UTC

[jira] Created: (HAMA-5) More Comments for maintainable code

More Comments for maintainable code
-----------------------------------

                 Key: HAMA-5
                 URL: https://issues.apache.org/jira/browse/HAMA-5
             Project: Hama
          Issue Type: Improvement
          Components: documentation 
            Reporter: Edward J. Yoon
            Assignee: Edward J. Yoon
            Priority: Critical


The comments are more important than code.
I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HAMA-5) More Comments for maintainable code

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon resolved HAMA-5.
-------------------------------

    Resolution: Won't Fix

Closing because this patch is too old.

> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>         Attachments: HAMA-5_v01.patch, HAMA-5_v02.patch
>
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-5) More Comments for maintainable code

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-5:
------------------------------

    Attachment: HAMA-5_v01.patch

Attached patch have some trivial changes.

> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>         Attachments: HAMA-5_v01.patch
>
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-5) More Comments for maintainable code

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-5:
------------------------------

    Attachment: HAMA-5_v02.patch

> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>         Attachments: HAMA-5_v01.patch, HAMA-5_v02.patch
>
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-5) More Comments for maintainable code

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620139#action_12620139 ] 

Edward J. Yoon commented on HAMA-5:
-----------------------------------

-added package.html as describe below.

* org.apache.hama : Dense and structured sparse matrices
* org.apache.hama.algebra : Algebraic operations on map/reduce
* org.apache.hama.io : I/O operations with matrices and vectors
* org.apache.hama.mapred : Map/Reduce Input/OutputFormats
* org.apache.hama.sparse : Unstructured sparse matrices



> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-5) More Comments for maintainable code

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621430#action_12621430 ] 

Edward J. Yoon commented on HAMA-5:
-----------------------------------

-added comments of AbstractBase.

> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-5) More Comments for maintainable code

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-5:
------------------------------

    Status: Open  (was: Patch Available)

Canceling.

> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>         Attachments: HAMA-5_v01.patch, HAMA-5_v02.patch
>
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-5) More Comments for maintainable code

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-5:
------------------------------

    Status: Patch Available  (was: Open)

Rescheduling.

> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>         Attachments: HAMA-5_v01.patch, HAMA-5_v02.patch
>
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-5) More Comments for maintainable code

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644006#action_12644006 ] 

Hudson commented on HAMA-5:
---------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12393066/HAMA-5_v01.patch
against trunk revision 708885.

    @author +1.  The patch does not contain any @author tags.

    tests included -1.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    patch -1.  The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/105/console

This message is automatically generated.

> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>         Attachments: HAMA-5_v01.patch
>
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-5) More Comments for maintainable code

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624334#action_12624334 ] 

Edward J. Yoon commented on HAMA-5:
-----------------------------------

I also add a util package which is provides numeric/variable utilities.

> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-5) More Comments for maintainable code

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-5:
------------------------------

    Status: Patch Available  (was: Open)

Submit to hudson.

> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>         Attachments: HAMA-5_v01.patch
>
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-5) More Comments for maintainable code

Posted by "Chanwit Kaewkasi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624195#action_12624195 ] 

Chanwit Kaewkasi commented on HAMA-5:
-------------------------------------

One more package for me, 

org.apache.hama.groovy

which will be containing groovy wrappers.

all for groovy-related will be in src/groovy (there will be some Java source files there as well).

> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-5) More Comments for maintainable code

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644194#action_12644194 ] 

Hudson commented on HAMA-5:
---------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12393119/HAMA-5_v02.patch
against trunk revision 708885.

    @author +1.  The patch does not contain any @author tags.

    tests included -1.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/106/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/106/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/106/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/106/console

This message is automatically generated.

> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>         Attachments: HAMA-5_v01.patch, HAMA-5_v02.patch
>
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-5) More Comments for maintainable code

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-5:
------------------------------

    Status: Open  (was: Patch Available)

> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>         Attachments: HAMA-5_v01.patch, HAMA-5_v02.patch
>
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-5) More Comments for maintainable code

Posted by "Yoon Joo Sun (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621664#action_12621664 ] 

Yoon Joo Sun commented on HAMA-5:
---------------------------------

how are you adding  package?
* org.apache.hama.hbase : support hbase 
* org.apache.hama.hadoop : support hadoop

cf)
* org.apache.hama : Dense and structured sparse matrices 
* org.apache.hama.algebra : Algebraic operations on map/reduce 
* org.apache.hama.io : I/O operations with matrices and vectors 
* org.apache.hama.sparse : Unstructured sparse matrices 
* org.apache.hama.hadoop : support hadoop(and support any version)
* org.apache.hama.hadoop.mapred : Map/Reduce Input/OutputFormats 
* org.apache.hama.hbase : support Hbase(and support any version)
* org.apache.hama.hbase.client : support Hbase client

> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-5) More Comments for maintainable code

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-5:
------------------------------

    Fix Version/s: 0.1.0

> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.