[GitHub] [druid] jihoonson commented on a change in pull request #11339: Fix setting wrong dictionary ID in PredicateFilteredDimensionSelector.getRow

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #11339:
URL: https://github.com/apache/druid/pull/11339#discussion_r647125307



##########
File path: processing/src/main/java/org/apache/druid/query/dimension/ListFilteredDimensionSpec.java
##########
@@ -88,7 +87,7 @@ public DimensionSelector decorate(final DimensionSelector selector)
   private DimensionSelector filterWhiteList(DimensionSelector selector)
   {
     final int selectorCardinality = selector.getValueCardinality();
-    if (selectorCardinality < 0 || (selector.idLookup() == null && !selector.nameLookupPossibleInAdvance())) {
+    if (selectorCardinality < 0 || !selector.nameLookupPossibleInAdvance()) {

Review comment:
       I'm not sure why it was there before, but I removed it because `ForwardingFilteredDimensionSelector` should not be used when the lookup is not possible in advance no matter whether `idLookup` is null or not (see the constructor of `ForwardingFilteredDimensionSelector`).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org