You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Stefan Seifert (JIRA)" <ji...@apache.org> on 2019/06/03 19:39:00 UTC
[jira] [Resolved] (SLING-8424) Enhance Request Parameter Handling
to Emulate HTML Forms
[ https://issues.apache.org/jira/browse/SLING-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Seifert resolved SLING-8424.
-----------------------------------
Resolution: Fixed
PR is merged
https://github.com/apache/sling-org-apache-sling-servlet-helpers/commit/c560996a22f48c1fc8df89b2f273f749b2f03139
> Enhance Request Parameter Handling to Emulate HTML Forms
> --------------------------------------------------------
>
> Key: SLING-8424
> URL: https://issues.apache.org/jira/browse/SLING-8424
> Project: Sling
> Issue Type: Improvement
> Components: Testing
> Affects Versions: Servlet Helpers 1.1.10
> Reporter: Rob McDougall
> Assignee: Stefan Seifert
> Priority: Major
> Fix For: Servlet Helpers 1.2.0
>
>
> Currently, the MockSlingHttpServletRequest class is set up to mock query parameters only. It assumes that all request parameters are Strings. It does not track things like contentType of each parameter.
> I've prototyped some changes to the code in order to allow the mocking of HTML form submissions (including file uploads). I'd like to submit a PR with those changes.
> I'm raising this issue for discussion before generating the PR in case there is any other ongoing work that I'm not aware of or if there are objections to the idea.
> If you want to preview the changes ahead of the PR, they are in a fork of the code available here: [https://github.com/rmcdouga/sling-org-apache-sling-servlet-helpers]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)