You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by al...@apache.org on 2022/09/19 06:27:35 UTC
[dubbo] branch 3.1 updated: Spell and code style optimization. (#10634)
This is an automated email from the ASF dual-hosted git repository.
albumenj pushed a commit to branch 3.1
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/3.1 by this push:
new 4206b5e67a Spell and code style optimization. (#10634)
4206b5e67a is described below
commit 4206b5e67a7f4c29d0dfff0d45b48d7749972f73
Author: Andy Cheung <wi...@users.noreply.github.com>
AuthorDate: Mon Sep 19 14:27:28 2022 +0800
Spell and code style optimization. (#10634)
---
.../org/apache/dubbo/common/compiler/support/JdkCompiler.java | 10 +++++-----
.../config/configcenter/AbstractDynamicConfiguration.java | 6 +++---
.../dubbo/common/config/configcenter/DynamicConfiguration.java | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/compiler/support/JdkCompiler.java b/dubbo-common/src/main/java/org/apache/dubbo/common/compiler/support/JdkCompiler.java
index 443690bca3..cebeaf7033 100644
--- a/dubbo-common/src/main/java/org/apache/dubbo/common/compiler/support/JdkCompiler.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/common/compiler/support/JdkCompiler.java
@@ -55,7 +55,7 @@ public class JdkCompiler extends AbstractCompiler {
private final JavaCompiler compiler = ToolProvider.getSystemJavaCompiler();
- private final DiagnosticCollector<JavaFileObject> diagnosticCollector = new DiagnosticCollector<JavaFileObject>();
+ private final DiagnosticCollector<JavaFileObject> diagnosticCollector = new DiagnosticCollector<>();
private final ClassLoaderImpl classLoader;
@@ -83,7 +83,7 @@ public class JdkCompiler extends AbstractCompiler {
&& (!"sun.misc.Launcher$AppClassLoader".equals(loader.getClass().getName()))) {
try {
URLClassLoader urlClassLoader = (URLClassLoader) loader;
- List<File> files = new ArrayList<File>();
+ List<File> files = new ArrayList<>();
for (URL url : urlClassLoader.getURLs()) {
files.add(new File(url.getFile()));
}
@@ -172,7 +172,7 @@ public class JdkCompiler extends AbstractCompiler {
private final ClassLoaderImpl classLoader;
- private final Map<URI, JavaFileObject> fileObjects = new HashMap<URI, JavaFileObject>();
+ private final Map<URI, JavaFileObject> fileObjects = new HashMap<>();
public JavaFileManagerImpl(JavaFileManager fileManager, ClassLoaderImpl classLoader) {
super(fileManager);
@@ -224,7 +224,7 @@ public class JdkCompiler extends AbstractCompiler {
ClassLoader contextClassLoader = Thread.currentThread().getContextClassLoader();
- ArrayList<JavaFileObject> files = new ArrayList<JavaFileObject>();
+ ArrayList<JavaFileObject> files = new ArrayList<>();
if (location == StandardLocation.CLASS_PATH && kinds.contains(JavaFileObject.Kind.CLASS)) {
for (JavaFileObject file : fileObjects.values()) {
@@ -252,7 +252,7 @@ public class JdkCompiler extends AbstractCompiler {
private static final class ClassLoaderImpl extends ClassLoader {
- private final Map<String, JavaFileObject> classes = new HashMap<String, JavaFileObject>();
+ private final Map<String, JavaFileObject> classes = new HashMap<>();
ClassLoaderImpl(final ClassLoader parentClassLoader) {
super(parentClassLoader);
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/config/configcenter/AbstractDynamicConfiguration.java b/dubbo-common/src/main/java/org/apache/dubbo/common/config/configcenter/AbstractDynamicConfiguration.java
index b5feab080c..164372d081 100644
--- a/dubbo-common/src/main/java/org/apache/dubbo/common/config/configcenter/AbstractDynamicConfiguration.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/common/config/configcenter/AbstractDynamicConfiguration.java
@@ -78,7 +78,7 @@ public abstract class AbstractDynamicConfiguration implements DynamicConfigurati
protected final ErrorTypeAwareLogger logger = LoggerFactory.getErrorTypeAwareLogger(getClass());
/**
- * The thread pool for workers who executes the tasks
+ * The thread pool for workers who execute the tasks
*/
private final ThreadPoolExecutor workersThreadPool;
@@ -86,12 +86,12 @@ public abstract class AbstractDynamicConfiguration implements DynamicConfigurati
private final long timeout;
- public AbstractDynamicConfiguration(URL url) {
+ protected AbstractDynamicConfiguration(URL url) {
this(getThreadPoolPrefixName(url), getThreadPoolSize(url), getThreadPoolKeepAliveTime(url), getGroup(url),
getTimeout(url));
}
- public AbstractDynamicConfiguration(String threadPoolPrefixName,
+ protected AbstractDynamicConfiguration(String threadPoolPrefixName,
int threadPoolSize,
long keepAliveTime,
String group,
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/config/configcenter/DynamicConfiguration.java b/dubbo-common/src/main/java/org/apache/dubbo/common/config/configcenter/DynamicConfiguration.java
index fcd08eb2b3..fc505d51a6 100644
--- a/dubbo-common/src/main/java/org/apache/dubbo/common/config/configcenter/DynamicConfiguration.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/common/config/configcenter/DynamicConfiguration.java
@@ -23,7 +23,7 @@ import org.apache.dubbo.common.config.Configuration;
/**
* Dynamic Configuration
* <br/>
- * From the use scenario internally inside framework, there're mainly three kinds of methods:
+ * From the use scenario internally inside framework, there are mainly three kinds of methods:
* <ol>
* <li>{@link #getProperties(String, String, long)}, get configuration file from Config Center at start up.</li>
* <li>{@link #addListener(String, String, ConfigurationListener)}/ {@link #removeListener(String, String, ConfigurationListener)}