You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "serrislew (via GitHub)" <gi...@apache.org> on 2024/05/09 19:41:50 UTC
[PR] Coverity 1523684: Resource leak [trafficserver]
serrislew opened a new pull request, #11338:
URL: https://github.com/apache/trafficserver/pull/11338
Adds deconstructor to delete AIOCallBackInternal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coverity 1523684: Resource leak [trafficserver]
Posted by "serrislew (via GitHub)" <gi...@apache.org>.
serrislew merged PR #11338:
URL: https://github.com/apache/trafficserver/pull/11338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coverity 1523684: Resource leak [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #11338:
URL: https://github.com/apache/trafficserver/pull/11338#discussion_r1599155173
##########
src/iocore/aio/test_AIO.cc:
##########
@@ -108,6 +108,13 @@ struct AIO_Device : public Continuation {
time_start = 0;
SET_HANDLER(&AIO_Device::do_hotset);
}
+ ~AIO_Device()
+ {
+ if (io) {
+ delete io;
+ io = nullptr;
+ }
Review Comment:
It was suggested in the PR/issue call that we could make this a unique_ptr. That's probably worthwhile doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coverity 1523684: Resource leak [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #11338:
URL: https://github.com/apache/trafficserver/pull/11338#issuecomment-2150604924
Cherry-picked to v10.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coverity 1523684: Resource leak [trafficserver]
Posted by "serrislew (via GitHub)" <gi...@apache.org>.
serrislew commented on PR #11338:
URL: https://github.com/apache/trafficserver/pull/11338#issuecomment-2127709306
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org