You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by franz1981 <gi...@git.apache.org> on 2018/03/27 18:00:58 UTC
[GitHub] activemq-artemis pull request #1976: ARTEMIS-1771 Porting of JDBC NodeManage...
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1976
ARTEMIS-1771 Porting of JDBC NodeManager into 1.5.5
https://issues.apache.org/jira/browse/ARTEMIS-1771
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franz1981/activemq-artemis 1_x_ARTEMIS-1771
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1976.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1976
----
----
---
[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1976
@clebertsuconic This PR now contains all the necessary commits: what we can do now?
I prefer to have just one PR with all the related commits in order to trace better why they were cherry-picked from 2.x, wdyt?
---
[GitHub] activemq-artemis pull request #1976: ARTEMIS-1771 Porting of JDBC NodeManage...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1976
---
[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1976
The CI tests are fine, but probably I will cherry-pick https://github.com/apache/activemq-artemis/pull/1977 too, in order to be feature complete.
---
[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1976
Please do not merge it yet, because I need to run the CI tests on it first :+1:
---
[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1976
Close this please? it's been merged
---
[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1976
@franz1981 rebase please
---
[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1976
if you could please review what's missing..
---
[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1976
Ouch. I merged it.
I will revert and push -f.
---
[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1976
Merged? But there was a missing commit to be cherry picked yet: https://github.com/apache/activemq-artemis/pull/1977
---
[GitHub] activemq-artemis issue #1976: ARTEMIS-1771 Porting of JDBC NodeManager into ...
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1976
@clebertsuconic Done, now there is just one commit into this PR :+1:
---