You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@helix.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2018/07/25 00:53:00 UTC
[jira] [Commented] (HELIX-745) [TASK] Make
AssignableInstanceManager listen on data changes to update
AssignableInstances
[ https://issues.apache.org/jira/browse/HELIX-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554969#comment-16554969 ]
Hudson commented on HELIX-745:
------------------------------
FAILURE: Integrated in Jenkins build helix #1527 (See [https://builds.apache.org/job/helix/1527/])
[HELIX-745] Make AssignableInstanceManager listen on data changes to (narendly: rev 0af6e8c19af5ee916f93acd8582e53b776e9c712)
* (edit) helix-core/src/main/java/org/apache/helix/task/AssignableInstanceManager.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/task/TestQuotaBasedScheduling.java
* (edit) helix-core/src/main/java/org/apache/helix/common/caches/TaskDataCache.java
* (edit) helix-core/src/main/java/org/apache/helix/controller/stages/ClusterDataCache.java
> [TASK] Make AssignableInstanceManager listen on data changes to update AssignableInstances
> ------------------------------------------------------------------------------------------
>
> Key: HELIX-745
> URL: https://issues.apache.org/jira/browse/HELIX-745
> Project: Apache Helix
> Issue Type: Improvement
> Reporter: Hunter L
> Priority: Major
>
> Previously, although AssignableInstanceManager provided an API for updating its AssignableInstances, this API was not being called at all. This RB fixes this.
> Changelist:
> 1. Add a boolean flag in ClusterDataCache for LiveInstance, ClusterConfig, InstanceConfig changes
> 2. If the ClusterDataCache is a taskDataCache, call AssignableInstanceManager.updateAssignableInstances() when the said boolean flag is true
> 3. Use thread-safe map in AssignableInstanceManager
> 4. Address the issue of targeted tasks having null taskIds (use pName convention instead)
> 5. Address the issue of LiveInstanceChange not notifying the caches by explicitly using setLiveInstance() function
> 6. Fix bug in restoreTaskAssignResult where tasks with null quota type were not being restored properly
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)