[jira] [Commented] (FINERACT-1060) UserNotFoundException at org.apache.fineract.useradministration.domain.AppUserRepositoryWrapper.fetchSystemUser()

["Michael Vorburger (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148124#comment-17148124 ] 

Michael Vorburger commented on FINERACT-1060:
---------------------------------------------

I only just fairly briefly investigated this, but am I getting this right that, basically, {{org.apache.fineract.useradministration.domain.AppUserRepositoryWrapper.fetchSystemUser()}} is just completely hard-coded to {{userName = "system"}}, and so given that this probably clearly does happen on https://www.fineract.dev, presumably, some clown :P probably had fun actually manually deleting this user on the demo server? 

Indeed, I don't see one (anymore) on https://cui.fineract.dev/?baseApiUrl=https://demo.fineract.dev&tenantIdentifier=default#/users/, and note that https://cui.fineract.dev/?baseApiUrl=https://demo.fineract.dev&tenantIdentifier=default#/viewuser/1 is the "mifos" demo login user, but https://cui.fineract.dev/?baseApiUrl=https://demo.fineract.dev&tenantIdentifier=default#/viewuser/2 is gone... is #2 usually this "system" user? (Check the initial SQL script.)

While this could probably be "fixed" by re-creating a "system" user... it begs another question - given that "system" is a hard-coded (!) user, shouldn't be lock this down much more, and prevent both deleting as well as renaming it? Just hard-coding a check for this seems a big ugly, but given that it's already hard-coded in that {{fetchSystemUser()}} anyway, that's probably reasonable? Or is {{fetchSystemUser()}} not such a great idea itself? I'm not sure how to easily get rid of - it's used in 4 places.

[~ptuomola] if you have any input on this, feel free to chime in...

> UserNotFoundException at org.apache.fineract.useradministration.domain.AppUserRepositoryWrapper.fetchSystemUser()
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: FINERACT-1060
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1060
>             Project: Apache Fineract
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Michael Vorburger
>            Priority: Blocker
>              Labels: beginner
>             Fix For: 1.4.0
>
>
> See FINERACT-932 for general background, and fix this problem:
> {noformat}org.quartz.SchedulerException: JobListener 'Global Listner' threw exception: null
> 	at org.quartz.core.QuartzScheduler.notifyJobListenersToBeExecuted(QuartzScheduler.java:1929) ~[quartz-2.3.2.jar:na]
> 	at org.quartz.core.JobRunShell.notifyListenersBeginning(JobRunShell.java:324) ~[quartz-2.3.2.jar:na]
> 	at org.quartz.core.JobRunShell.run(JobRunShell.java:173) ~[quartz-2.3.2.jar:na]
> 	at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:573) ~[quartz-2.3.2.jar:na]
> Caused by: org.apache.fineract.useradministration.exception.UserNotFoundException: null
> 	at org.apache.fineract.useradministration.domain.AppUserRepositoryWrapper.fetchSystemUser(AppUserRepositoryWrapper.java:39) ~[app/:na]
> 	at org.apache.fineract.infrastructure.jobs.service.SchedulerJobListener.jobToBeExecuted(SchedulerJobListener.java:70) ~[app/:na]
> 	at org.quartz.core.QuartzScheduler.notifyJobListenersToBeExecuted(QuartzScheduler.java:1927) ~[quartz-2.3.2.jar:na]{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)