You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/20 14:23:54 UTC

[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #1020: Fix don't duplicate killed clients which have already flagged kCloseAfterReply

tisonkun commented on code in PR #1020:
URL: https://github.com/apache/incubator-kvrocks/pull/1020#discussion_r1000706539


##########
src/server/worker.cc:
##########
@@ -430,6 +430,10 @@ void Worker::KillClient(Redis::Connection *self, uint64_t id, std::string addr,
   for (const auto &iter : conns_) {
     Redis::Connection *conn = iter.second;
     if (skipme && self == conn) continue;
+    // no need to kill again the client if flags as kCloseAfterReply

Review Comment:
   So we kill clients asynchronously?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org