You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com> on 2015/05/13 19:36:15 UTC
Re: Review Request 34009: SAMZA-552 window store implementation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34009/
-----------------------------------------------------------
(Updated May 13, 2015, 5:36 p.m.)
Review request for samza, Chris Riccomini, Guozhang Wang, Milinda Pathirage, Navina Ramesh, and Naveen Somasundaram.
Summary (updated)
-----------------
SAMZA-552 window store implementation
Bugs: SAMZA-552
https://issues.apache.org/jira/browse/SAMZA-552
Repository: samza
Description
-------
SAMZA-650: adding updateOutputs(), getResult(), and flush() in window operator. Adding example code as use case for window operator.
This is to solicitate the iteration on the change of Operator APIs to make it simpler for programmers.
* Main highlights:
* Removed differentiation between RelationOperator and TupleOperator
* Added OperatorCallback interface to allow user to insert callback functions to be invoked before process the input and before send the result
* Simplified test task implementation
WIP:
* Implementation of window store and message store
Diffs
-----
samza-sql-core/src/main/java/org/apache/samza/sql/api/data/EntityName.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Relation.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Stream.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Tuple.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/Operator.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/OperatorCallback.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/RelationOperator.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/SimpleOperator.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/SqlOperatorFactory.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/TupleOperator.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/spec/OperatorSpec.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/api/router/OperatorRouter.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/data/IncomingMessageTuple.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/exception/OperatorException.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/DefaultOperatorCallback.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperator.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorFactoryImpl.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorImpl.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorSpec.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleRouter.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoin.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionOp.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionSpec.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/relation/Join.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/relation/JoinSpec.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/stream/InsertStream.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/stream/InsertStreamSpec.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/BoundedTimeWindow.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateTimeWindow.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateTimeWindowOp.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateWindowOp.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/RetentionPolicy.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowOp.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowOpSpec.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowSpec.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowState.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/router/SimpleRouter.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/FilteredMessageIterator.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/HashPrefixedMessageStore.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/MessageStore.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/MessageStoreSpec.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/OrderedStoreKey.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/PrefixedKey.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/Range.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/TimeAndOffsetKey.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/TimeKey.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/WindowOutputStream.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/WindowState.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/WindowStore.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/system/sql/LongOffset.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/system/sql/Offset.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/task/sql/OperatorMessageCollector.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/task/sql/RouterMessageCollector.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/task/sql/SimpleMessageCollector.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/task/sql/SqlMessageCollector.java PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/task/sql/StoreMessageCollector.java PRE-CREATION
samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomOperatorTask.java PRE-CREATION
samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomWindowOperatorTask.java PRE-CREATION
samza-sql-core/src/test/java/org/apache/samza/task/sql/StreamSqlTask.java PRE-CREATION
samza-sql-core/src/test/java/org/apache/samza/task/sql/UserCallbacksSqlTask.java PRE-CREATION
Diff: https://reviews.apache.org/r/34009/diff/
Testing
-------
./gradlew clean build passed
Thanks,
Yi Pan (Data Infrastructure)
Re: Review Request 34009: SAMZA-552 window store implementation
Posted by Navina Ramesh <nr...@linkedin.com>.
> On May 13, 2015, 9:56 p.m., Navina Ramesh wrote:
> > samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomWindowOperatorTask.java, line 96
> > <https://reviews.apache.org/r/34009/diff/1/?file=954320#file954320line96>
> >
> > Shouldn't the window id be system generated?
>
> Yi Pan (Data Infrastructure) wrote:
> Yes, in the case when the whole query plan is system-generated. Here we just illustrate how a human programmer can instantiate and use the window operators.
Ok. Got it!
- Navina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34009/#review83667
-----------------------------------------------------------
On May 13, 2015, 5:36 p.m., Yi Pan (Data Infrastructure) wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34009/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 5:36 p.m.)
>
>
> Review request for samza, Chris Riccomini, Guozhang Wang, Milinda Pathirage, Navina Ramesh, and Naveen Somasundaram.
>
>
> Bugs: SAMZA-552
> https://issues.apache.org/jira/browse/SAMZA-552
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-650: adding updateOutputs(), getResult(), and flush() in window operator. Adding example code as use case for window operator.
>
> This is to solicitate the iteration on the change of Operator APIs to make it simpler for programmers.
> * Main highlights:
> * Removed differentiation between RelationOperator and TupleOperator
> * Added OperatorCallback interface to allow user to insert callback functions to be invoked before process the input and before send the result
> * Simplified test task implementation
>
> WIP:
> * Implementation of window store and message store
>
>
> Diffs
> -----
>
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/EntityName.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Relation.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Stream.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Tuple.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/Operator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/OperatorCallback.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/RelationOperator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/SimpleOperator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/SqlOperatorFactory.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/TupleOperator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/spec/OperatorSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/router/OperatorRouter.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/IncomingMessageTuple.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/exception/OperatorException.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/DefaultOperatorCallback.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorFactoryImpl.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorImpl.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleRouter.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoin.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionOp.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/relation/Join.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/relation/JoinSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/stream/InsertStream.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/stream/InsertStreamSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/BoundedTimeWindow.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateTimeWindow.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateTimeWindowOp.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateWindowOp.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/RetentionPolicy.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowOp.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowOpSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowState.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/router/SimpleRouter.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/FilteredMessageIterator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/HashPrefixedMessageStore.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/MessageStore.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/MessageStoreSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/OrderedStoreKey.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/PrefixedKey.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/Range.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/TimeAndOffsetKey.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/TimeKey.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/WindowOutputStream.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/WindowState.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/WindowStore.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/system/sql/LongOffset.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/system/sql/Offset.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/OperatorMessageCollector.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/RouterMessageCollector.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/SimpleMessageCollector.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/SqlMessageCollector.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/StoreMessageCollector.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomOperatorTask.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomWindowOperatorTask.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/StreamSqlTask.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/UserCallbacksSqlTask.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34009/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build passed
>
>
> Thanks,
>
> Yi Pan (Data Infrastructure)
>
>
Re: Review Request 34009: SAMZA-552 window store implementation
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
> On May 13, 2015, 9:56 p.m., Navina Ramesh wrote:
> > samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateTimeWindowOp.java, line 309
> > <https://reviews.apache.org/r/34009/diff/1/?file=954292#file954292line309>
> >
> > There are 2 refresh method definitions - one is internal and other is public api?
> >
> > When is this refresh method invoked?
This is probably a mess-up in the operator API changes. I will fix it. Thanks!
> On May 13, 2015, 9:56 p.m., Navina Ramesh wrote:
> > samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomWindowOperatorTask.java, line 96
> > <https://reviews.apache.org/r/34009/diff/1/?file=954320#file954320line96>
> >
> > Shouldn't the window id be system generated?
Yes, in the case when the whole query plan is system-generated. Here we just illustrate how a human programmer can instantiate and use the window operators.
- Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34009/#review83667
-----------------------------------------------------------
On May 13, 2015, 5:36 p.m., Yi Pan (Data Infrastructure) wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34009/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 5:36 p.m.)
>
>
> Review request for samza, Chris Riccomini, Guozhang Wang, Milinda Pathirage, Navina Ramesh, and Naveen Somasundaram.
>
>
> Bugs: SAMZA-552
> https://issues.apache.org/jira/browse/SAMZA-552
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-650: adding updateOutputs(), getResult(), and flush() in window operator. Adding example code as use case for window operator.
>
> This is to solicitate the iteration on the change of Operator APIs to make it simpler for programmers.
> * Main highlights:
> * Removed differentiation between RelationOperator and TupleOperator
> * Added OperatorCallback interface to allow user to insert callback functions to be invoked before process the input and before send the result
> * Simplified test task implementation
>
> WIP:
> * Implementation of window store and message store
>
>
> Diffs
> -----
>
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/EntityName.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Relation.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Stream.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Tuple.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/Operator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/OperatorCallback.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/RelationOperator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/SimpleOperator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/SqlOperatorFactory.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/TupleOperator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/spec/OperatorSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/router/OperatorRouter.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/IncomingMessageTuple.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/exception/OperatorException.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/DefaultOperatorCallback.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorFactoryImpl.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorImpl.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleRouter.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoin.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionOp.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/relation/Join.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/relation/JoinSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/stream/InsertStream.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/stream/InsertStreamSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/BoundedTimeWindow.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateTimeWindow.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateTimeWindowOp.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateWindowOp.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/RetentionPolicy.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowOp.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowOpSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowState.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/router/SimpleRouter.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/FilteredMessageIterator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/HashPrefixedMessageStore.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/MessageStore.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/MessageStoreSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/OrderedStoreKey.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/PrefixedKey.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/Range.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/TimeAndOffsetKey.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/TimeKey.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/WindowOutputStream.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/WindowState.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/WindowStore.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/system/sql/LongOffset.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/system/sql/Offset.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/OperatorMessageCollector.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/RouterMessageCollector.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/SimpleMessageCollector.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/SqlMessageCollector.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/StoreMessageCollector.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomOperatorTask.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomWindowOperatorTask.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/StreamSqlTask.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/UserCallbacksSqlTask.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34009/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build passed
>
>
> Thanks,
>
> Yi Pan (Data Infrastructure)
>
>
Re: Review Request 34009: SAMZA-552 window store implementation
Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34009/#review83667
-----------------------------------------------------------
samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateTimeWindowOp.java
<https://reviews.apache.org/r/34009/#comment134683>
There are 2 refresh method definitions - one is internal and other is public api?
When is this refresh method invoked?
samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomWindowOperatorTask.java
<https://reviews.apache.org/r/34009/#comment134678>
Shouldn't the window id be system generated?
- Navina Ramesh
On May 13, 2015, 5:36 p.m., Yi Pan (Data Infrastructure) wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34009/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 5:36 p.m.)
>
>
> Review request for samza, Chris Riccomini, Guozhang Wang, Milinda Pathirage, Navina Ramesh, and Naveen Somasundaram.
>
>
> Bugs: SAMZA-552
> https://issues.apache.org/jira/browse/SAMZA-552
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-650: adding updateOutputs(), getResult(), and flush() in window operator. Adding example code as use case for window operator.
>
> This is to solicitate the iteration on the change of Operator APIs to make it simpler for programmers.
> * Main highlights:
> * Removed differentiation between RelationOperator and TupleOperator
> * Added OperatorCallback interface to allow user to insert callback functions to be invoked before process the input and before send the result
> * Simplified test task implementation
>
> WIP:
> * Implementation of window store and message store
>
>
> Diffs
> -----
>
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/EntityName.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Relation.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Stream.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Tuple.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/Operator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/OperatorCallback.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/RelationOperator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/SimpleOperator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/SqlOperatorFactory.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/TupleOperator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/spec/OperatorSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/api/router/OperatorRouter.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/data/IncomingMessageTuple.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/exception/OperatorException.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/DefaultOperatorCallback.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorFactoryImpl.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorImpl.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleRouter.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoin.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionOp.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/relation/Join.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/relation/JoinSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/stream/InsertStream.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/stream/InsertStreamSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/BoundedTimeWindow.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateTimeWindow.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateTimeWindowOp.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/FullStateWindowOp.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/RetentionPolicy.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowOp.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowOpSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowState.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/router/SimpleRouter.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/FilteredMessageIterator.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/HashPrefixedMessageStore.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/MessageStore.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/MessageStoreSpec.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/OrderedStoreKey.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/PrefixedKey.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/Range.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/TimeAndOffsetKey.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/TimeKey.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/WindowOutputStream.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/WindowState.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/sql/window/storage/WindowStore.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/system/sql/LongOffset.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/system/sql/Offset.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/OperatorMessageCollector.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/RouterMessageCollector.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/SimpleMessageCollector.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/SqlMessageCollector.java PRE-CREATION
> samza-sql-core/src/main/java/org/apache/samza/task/sql/StoreMessageCollector.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomOperatorTask.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomWindowOperatorTask.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/StreamSqlTask.java PRE-CREATION
> samza-sql-core/src/test/java/org/apache/samza/task/sql/UserCallbacksSqlTask.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34009/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build passed
>
>
> Thanks,
>
> Yi Pan (Data Infrastructure)
>
>