You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by swegner <gi...@git.apache.org> on 2016/12/06 22:24:48 UTC

[GitHub] incubator-beam pull request #1522: [BEAM-1097] Provide a better error messag...

GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam/pull/1522

    [BEAM-1097] Provide a better error message for non-existing gcpTempLocation

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    gcpTempLocation will default to using the value for tmpLocation, as long
    as the value is a valid GCP path. Non-valid GCP paths are silently
    discarded.
    
    This change removes existence validation from the default value logic
    such that downstream validation can provide a better error message.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam gcp-temp-location-error

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1522.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1522
    
----
commit 9d768df4323a246baa705fd5fb75d08c78abb7f0
Author: Scott Wegner <sw...@google.com>
Date:   2016-12-06T22:19:12Z

    Provide a better error message for non-existing gcpTempLocation
    
    gcpTempLocation will default to using the value for tmpLocation, as long
    as the value is a valid GCP path. Non-valid GCP paths are silently
    discarded.
    
    This change removes existence validation from the default value logic
    such that downstream validation can provide a better error message.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #1522: [BEAM-1097] Provide a better error messag...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1522


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---