You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Jacek Laskowski <ja...@laskowski.net.pl> on 2008/05/05 22:46:36 UTC
Re: svn commit: r653588 - in /geronimo/server/trunk/framework/modules: geronimo-kernel/src/main/java/org/apache/geronimo/gbean/runtime/ geronimo-kernel/src/main/java/org/apache/geronimo/kernel/config/ geronimo-kernel/src/main/java/org/apache/geronimo
On Mon, May 5, 2008 at 10:34 PM, <jd...@apache.org> wrote:
> Author: jdillon
> Date: Mon May 5 13:34:06 2008
> New Revision: 653588
>
> URL: http://svn.apache.org/viewvc?rev=653588&view=rev
> Log:
> Start of custom SLF4J muck for Geronimo
> - log.trace("Checking if child is running: child=" + child);
> + log.trace("Checking if child is running: child={}", child);
Is it intentional? Will it work without the numbering like {0}? I see
it occuring everywhere in the submitted code so it seems to be the way
it works, but thought I'd ask for some pointers.
Jacek
--
Jacek Laskowski
http://www.JacekLaskowski.pl
Re: svn commit: r653588 - in /geronimo/server/trunk/framework/modules: geronimo-kernel/src/main/java/org/apache/geronimo/gbean/runtime/ geronimo-kernel/src/main/java/org/apache/geronimo/kernel/config/ geronimo-kernel/src/main/java/org/apache/geronimo
Posted by Jason Dillon <ja...@planet57.com>.
Yes, this is intentional. SLF4J has some optimized code to deal with
"{}" strings for substitution.
--jason
On May 6, 2008, at 3:46 AM, Jacek Laskowski wrote:
> On Mon, May 5, 2008 at 10:34 PM, <jd...@apache.org> wrote:
>> Author: jdillon
>> Date: Mon May 5 13:34:06 2008
>> New Revision: 653588
>>
>> URL: http://svn.apache.org/viewvc?rev=653588&view=rev
>> Log:
>> Start of custom SLF4J muck for Geronimo
>
>> - log.trace("Checking if child is running: child=" +
>> child);
>> + log.trace("Checking if child is running:
>> child={}", child);
>
> Is it intentional? Will it work without the numbering like {0}? I see
> it occuring everywhere in the submitted code so it seems to be the way
> it works, but thought I'd ask for some pointers.
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.JacekLaskowski.pl