Re: [PR] [SPARK-45533][CORE] Use j.l.r.Cleaner instead of finalize for RocksDBIterator [spark]

["zhaomin1423 (via GitHub)" <gi...@apache.org>]

zhaomin1423 commented on code in PR #43502:
URL: https://github.com/apache/spark/pull/43502#discussion_r1371239368


##########
common/kvstore/src/test/java/org/apache/spark/util/kvstore/DBIteratorSuite.java:
##########
@@ -506,5 +506,4 @@ private List<CustomType1> sortBy(Comparator<CustomType1> comp) {
     Collections.sort(copy, comp);
     return copy;
   }
-

Review Comment:
   done



##########
common/kvstore/src/test/java/org/apache/spark/util/kvstore/RocksDBIteratorSuite.java:
##########
@@ -44,5 +44,4 @@ protected KVStore createStore() throws Exception {
     db = new RocksDB(dbpath);
     return db;
   }
-

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org