You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "showuon (via GitHub)" <gi...@apache.org> on 2023/05/29 09:53:34 UTC

[GitHub] [kafka] showuon opened a new pull request, #13775: MINOR: update release.py

showuon opened a new pull request, #13775:
URL: https://github.com/apache/kafka/pull/13775

   Update release.py script:
   1. fix typo
   2. remove non-existed `kafka-clients@googlegroups.com`
   3. add more info about closing repository in stagingRepository
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on a diff in pull request #13775: MINOR: update release.py

Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #13775:
URL: https://github.com/apache/kafka/pull/13775#discussion_r1211397639


##########
release.py:
##########
@@ -698,7 +700,7 @@ def select_gpg_key():
 
 
 email_contents = """
-To: dev@kafka.apache.org, users@kafka.apache.org, kafka-clients@googlegroups.com
+To: dev@kafka.apache.org, users@kafka.apache.org

Review Comment:
   Ah, I didn't know that. Thanks for the info.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon merged pull request #13775: MINOR: update release.py

Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon merged PR #13775:
URL: https://github.com/apache/kafka/pull/13775


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mimaison commented on a diff in pull request #13775: MINOR: update release.py

Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #13775:
URL: https://github.com/apache/kafka/pull/13775#discussion_r1209862688


##########
release.py:
##########
@@ -698,7 +700,7 @@ def select_gpg_key():
 
 
 email_contents = """
-To: dev@kafka.apache.org, users@kafka.apache.org, kafka-clients@googlegroups.com
+To: dev@kafka.apache.org, users@kafka.apache.org

Review Comment:
   `kafka-clients@googlegroups.com` exists, see https://groups.google.com/u/1/g/kafka-clients
   To send emails you need to be subscribed to the group, it's documented in https://cwiki.apache.org/confluence/display/KAFKA/Release+Process
   ```
   You need to be subscribed to `[kafka-clients@googlegroups.com](mailto:kafka-clients@googlegroups.com)` with your apache email address – otherwise it bounces back. Just send a message from your apache email to [kafka-clients+subscribe@googlegroups.com](mailto:kafka-clients+subscribe@googlegroups.com) and click `Join` in the confirmation email
   ```



##########
release.py:
##########
@@ -684,6 +684,8 @@ def select_gpg_key():
 print("Next, we need to get the Maven artifacts we published into the staging repository.")
 # TODO: Can we get this closed via a REST API since we already need to collect credentials for this repo?
 print("Go to https://repository.apache.org/#stagingRepositories and hit 'Close' for the new repository that was created by uploading artifacts.")
+print("There will be more than one repository entries created, please close all of them.")
+print("There's a known issue that the repository close will be failed: KAFKA-15033.")

Review Comment:
   What about:
   ```
   In some cases, you may get errors on some repositories while closing them, see KAFKA-15033.
   ```
   
   I did not see this while running 3.5.0 RC0, but yes I saw it in the past.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #13775: MINOR: update release.py

Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #13775:
URL: https://github.com/apache/kafka/pull/13775#issuecomment-1566874959

   @mimaison , call for review. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on a diff in pull request #13775: MINOR: update release.py

Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #13775:
URL: https://github.com/apache/kafka/pull/13775#discussion_r1211399769


##########
release.py:
##########
@@ -684,6 +684,8 @@ def select_gpg_key():
 print("Next, we need to get the Maven artifacts we published into the staging repository.")
 # TODO: Can we get this closed via a REST API since we already need to collect credentials for this repo?
 print("Go to https://repository.apache.org/#stagingRepositories and hit 'Close' for the new repository that was created by uploading artifacts.")
+print("There will be more than one repository entries created, please close all of them.")
+print("There's a known issue that the repository close will be failed: KAFKA-15033.")

Review Comment:
   Yes, it looks better. Updated. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org