You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/03/27 15:27:44 UTC

[GitHub] [skywalking-banyandb-java-client] wu-sheng edited a comment on pull request #7: Add measure API for Java Client

wu-sheng edited a comment on pull request #7:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/7#issuecomment-1079953336


   > Since we have to create three types of resources in one method, it is necessary to query again in order to combine them together.
   
   If you want to add a verification, then it should be another API. You should not combine internally. Because even you have combined, another client could update it, it is pointless. If some incompatible rules added, an exception should be thrown out.
   
   > I also think this API is not appropriate. What about the following one?
   
   Take a look at my comment above first, then this is not necessary. Don't expose the index binding mechanism to users, because we don't share rules among measure/stream.
   
   In conclusion, don't merge the rules. What the client only knows the rules this definition declared.
   
   > It is short enough and provides more degree of freedom.
   
   From API design perspective, we don't expose more freedom, we just provide necessary freedom. This style is from the first Java agent tracing APIs.
   
   > > I can't find the Properties APIs, is it going to add later?
   
   > This feature has not yet been implemented in BanyanDB.
   
   @hanahmily Can you confirm the status? I thought you mentioned topN is the last feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org