You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/02 06:51:19 UTC

[GitHub] [rocketmq-schema-registry] MatrixHB opened a new pull request, #23: [bugfix] fix some problems when testing the SchemaRegistryClient

MatrixHB opened a new pull request, #23:
URL: https://github.com/apache/rocketmq-schema-registry/pull/23

   bug1: When updating the schema, the audit info will be lost.
   
   bug2: When throwing SchemaNotFoundException, the massage cannot be parsed to JSON.
   
   bug3: After delete the schema by subject, we will send a message with _DELETE_KEY_ so that the local cache can be refreshed. But when the registry server restart and the local cache replay, maybe we will consume the _DELETE_KEY_ massage first and then consume the schema message, thus the deleted schema will regenerate in local cache, inconsistent with remote storage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-schema-registry] codecov-commenter commented on pull request #23: [bugfix] fix some problems when testing the SchemaRegistryClient

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23:
URL: https://github.com/apache/rocketmq-schema-registry/pull/23#issuecomment-1202132864

   # [Codecov](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/23?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#23](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/23?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7aeeadd) into [main](https://codecov.io/gh/apache/rocketmq-schema-registry/commit/e85fbf7afeb7d43694f7974828e51720a1ee0645?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e85fbf7) will **not change** coverage.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@          Coverage Diff          @@
   ##            main     #23   +/-   ##
   =====================================
     Coverage   0.00%   0.00%           
   =====================================
     Files         16      16           
     Lines        367     369    +2     
     Branches      16      17    +1     
   =====================================
   - Misses       367     369    +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...chema/registry/core/service/SchemaServiceImpl.java](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/23/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc2NoZW1hL3JlZ2lzdHJ5L2NvcmUvc2VydmljZS9TY2hlbWFTZXJ2aWNlSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
   
   Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-schema-registry] duhenglucky merged pull request #23: [bugfix] fix some problems when testing the SchemaRegistryClient

Posted by GitBox <gi...@apache.org>.
duhenglucky merged PR #23:
URL: https://github.com/apache/rocketmq-schema-registry/pull/23


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org