[GitHub] [airflow] pierrejeambrun commented on pull request #29390: Fix grid logs for large logs

["pierrejeambrun (via GitHub)" <gi...@apache.org>]

pierrejeambrun commented on PR #29390:
URL: https://github.com/apache/airflow/pull/29390#issuecomment-1419556849

   Thanks Brent for this fix.
   
   'Full Logs' impacts only how we request logs to the rest API. Most of the time, without requesting full logs, reading by chunk/tail will be enough to avoid most of UI issues due to large file. Unfortunatly if a log chunk contains a really really long line we can still have a huge chunk, Brent sample shows 1 line of log that is 5Mb of text by itself and this can will cause rendering + performance issues.
   
   I agree that the wording between these two elements are a bit confusing.
   
   > Note: Looking at the get_task_log implementation, we use streaming capabilities, with `read_log_stream` but aggregate everything before returning the payload. I must be missing something, but I am wondering if this 'Full Logs' really makes sense for us here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org