[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6095: chore(deps): update regex and regex-syntax requirement from 0.6.28 to 0.7.1

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6095:
URL: https://github.com/apache/arrow-datafusion/pull/6095#discussion_r1174405943


##########
datafusion/optimizer/src/simplify_expressions/regex.rs:
##########
@@ -124,7 +142,8 @@ fn lower_simple(mode: &OperatorMode, left: &Expr, hir: &Hir) -> Option<Expr> {
         HirKind::Empty => {
             return Some(mode.expr(Box::new(left.clone()), "%".to_owned()));
         }
-        HirKind::Literal(Literal::Unicode(c)) if is_safe_for_like(*c) => {
+        HirKind::Literal(l) => {

Review Comment:
   the API has changed from having a Unicode char to a `Box<u8>` so I updated this code to match



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org