You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2018/03/28 15:03:04 UTC

Review Request 66333: ATLAS-2515 :- Fix authorization while adding classification to the entity fails if there is no read classification permission

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66333/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.


Bugs: ATLAS-2515
    https://issues.apache.org/jira/browse/ATLAS-2515


Repository: atlas


Description
-------

This patch includes changes to not perform read classification authz check while adding classification to entity.

Also corrected the authz priveledge to ENTITY_REMOVE_CLASSIFICATION while delete classification of entity


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6fe85702 


Diff: https://reviews.apache.org/r/66333/diff/1/


Testing
-------

Tested authz with and without read-classification permission for the user while adding classification to entity.


Thanks,

Nixon Rodrigues


Re: Review Request 66333: ATLAS-2515 :- Fix authorization while adding classification to the entity fails if there is no read classification permission

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66333/#review200128
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On March 28, 2018, 3:03 p.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66333/
> -----------------------------------------------------------
> 
> (Updated March 28, 2018, 3:03 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2515
>     https://issues.apache.org/jira/browse/ATLAS-2515
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch includes changes to not perform read classification authz check while adding classification to entity.
> 
> Also corrected the authz priveledge to ENTITY_REMOVE_CLASSIFICATION while delete classification of entity
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6fe85702 
> 
> 
> Diff: https://reviews.apache.org/r/66333/diff/1/
> 
> 
> Testing
> -------
> 
> Tested authz with and without read-classification permission for the user while adding classification to entity.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>