You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/26 08:09:58 UTC
[GitHub] [shardingsphere] jiangML opened a new pull request, #23101: Optimize agent module
jiangML opened a new pull request, #23101:
URL: https://github.com/apache/shardingsphere/pull/23101
For #23100
Changes proposed in this pull request:
- Merge agent-core into agent-bootstrap
- Split TimeRecorder, AgentReflectionUtil, RemotePluginConfigurationValidator into new shardingsphere-agent-plugin-core module
- Add dependency shade
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23101: Optimize agent module
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23101:
URL: https://github.com/apache/shardingsphere/pull/23101#issuecomment-1365028565
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23101?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23101](https://codecov.io/gh/apache/shardingsphere/pull/23101?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6ae7ba7) into [master](https://codecov.io/gh/apache/shardingsphere/commit/01f4968387cb1bb97c3079767427633442ab4bd6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (01f4968) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #23101 +/- ##
=========================================
Coverage 49.95% 49.96%
Complexity 2433 2433
=========================================
Files 4112 4112
Lines 57478 57478
Branches 9086 9086
=========================================
+ Hits 28714 28717 +3
+ Misses 26253 26250 -3
Partials 2511 2511
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ingsphere/agent/bootstrap/ShardingSphereAgent.java](https://codecov.io/gh/apache/shardingsphere/pull/23101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvU2hhcmRpbmdTcGhlcmVBZ2VudC5qYXZh) | `0.00% <ø> (ø)` | |
| [.../agent/bootstrap/classloader/AgentClassLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvY2xhc3Nsb2FkZXIvQWdlbnRDbGFzc0xvYWRlci5qYXZh) | `17.30% <ø> (ø)` | |
| [...strap/config/loader/PluginConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvY29uZmlnL2xvYWRlci9QbHVnaW5Db25maWd1cmF0aW9uTG9hZGVyLmphdmE=) | `88.88% <ø> (ø)` | |
| [...g/yaml/entity/YamlPluginCategoryConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvY29uZmlnL3lhbWwvZW50aXR5L1lhbWxQbHVnaW5DYXRlZ29yeUNvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ap/config/yaml/entity/YamlPluginConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvY29uZmlnL3lhbWwvZW50aXR5L1lhbWxQbHVnaW5Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
| [...p/config/yaml/entity/YamlPluginsConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvY29uZmlnL3lhbWwvZW50aXR5L1lhbWxQbHVnaW5zQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
| [.../yaml/swapper/YamlPluginsConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/23101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvY29uZmlnL3lhbWwvc3dhcHBlci9ZYW1sUGx1Z2luc0NvbmZpZ3VyYXRpb25Td2FwcGVyLmphdmE=) | `85.71% <ø> (ø)` | |
| [...gsphere/agent/bootstrap/logging/LoggerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/23101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvbG9nZ2luZy9Mb2dnZXJGYWN0b3J5LmphdmE=) | `47.50% <ø> (ø)` | |
| [...phere/agent/bootstrap/logging/LoggingListener.java](https://codecov.io/gh/apache/shardingsphere/pull/23101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvbG9nZ2luZy9Mb2dnaW5nTGlzdGVuZXIuamF2YQ==) | `77.77% <ø> (ø)` | |
| [...gsphere/agent/bootstrap/path/AgentPathBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/23101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvcGF0aC9BZ2VudFBhdGhCdWlsZGVyLmphdmE=) | `57.89% <ø> (ø)` | |
| ... and [39 more](https://codecov.io/gh/apache/shardingsphere/pull/23101/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #23101: Optimize agent module
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #23101:
URL: https://github.com/apache/shardingsphere/pull/23101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org