[GitHub] [incubator-tvm] kazum commented on a change in pull request #5192: [FRONTEND][MXNET] Use leaky by default for LeakyReLU

[GitBox <gi...@apache.org>]

kazum commented on a change in pull request #5192: [FRONTEND][MXNET] Use leaky by default for LeakyReLU
URL: https://github.com/apache/incubator-tvm/pull/5192#discussion_r401172125
 
 

 ##########
 File path: tests/python/frontend/mxnet/test_forward.py
 ##########
 @@ -107,6 +107,14 @@ def test_forward_resnet():
         mx_sym = model_zoo.mx_resnet(18)
         verify_mxnet_frontend_impl(mx_sym)
 
+def test_forward_leaky_relu():
+    data = mx.sym.var('data')
+    data = mx.sym.concat(data, -data, dim=1)  # negative part explicitly
+    mx_sym = mx.sym.LeakyReLU(data)
+    verify_mxnet_frontend_impl(mx_sym, (1, 3, 100, 100), (1, 6, 100, 100))
+    mx_sym = mx.sym.LeakyReLU(data, act_type='leaky')
 
 Review comment:
   The only leaky relu has two patterns to be applied.  Having two tests for it looks good to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services