You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/12/11 14:39:32 UTC

[GitHub] [mynewt-core] kasjer commented on issue #2106: PR for 3 changes : NDEBUG build, fix SPI on STM32, bitbang uart tx only

kasjer commented on issue #2106: PR for 3 changes : NDEBUG build, fix SPI on STM32, bitbang uart tx only
URL: https://github.com/apache/mynewt-core/pull/2106#issuecomment-564574096
 
 
   Hi @brianwyld  you have better chances to merge you changes if you split you pr #2106. Removing restriction on bit bang uart (no need for RX) seems like reasonable and should not face with much resistance. Fix STM32 gpio is also separate thing. With assert related stuff you can still hit the wall and users who created mynewt in the first place may have something to say. I also refrained from pointing out every single c++ style comment that is still out there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services