You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/17 13:47:39 UTC

[GitHub] [spark] LuciferYang commented on a change in pull request #35898: [SPARK-38544][BUILD] Revert "Revert "[SPARK-38544][BUILD] Upgrade log4j2 to 2.17.2""

LuciferYang commented on a change in pull request #35898:
URL: https://github.com/apache/spark/pull/35898#discussion_r829132798



##########
File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SparkConfPropagateSuite.scala
##########
@@ -42,7 +42,7 @@ private[spark] trait SparkConfPropagateSuite { k8sSuite: KubernetesSuite =>
       sparkAppConf.set("spark.kubernetes.executor.deleteOnTermination", "false")
 
       val log4jExpectedLog =
-        Seq("Reconfiguration complete for context", "at URI /opt/spark/conf/log4j2.properties")
+        Seq("Reconfiguration complete for context", "at URI /opt/spark/conf", "/log4j2.properties")

Review comment:
       I think we should add some comments for this change in code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org