You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/18 07:11:16 UTC
[GitHub] [incubator-superset] rusackas commented on issue #8857: Removing
some dividers to make header dropdown menus more consistent
rusackas commented on issue #8857: Removing some dividers to make header dropdown menus more consistent
URL: https://github.com/apache/incubator-superset/pull/8857#issuecomment-566898391
> Does this still render everything properly when you have the Druid REST Connector active?
Well, that depends on what we call "proper" I guess :)
As it stands, this PR removes the horizontal rules:
But since Druid adds four menu options, I could see the argument to add one in above the Druid-items like so:
Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org