You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/21 04:46:20 UTC

[GitHub] [incubator-doris] lingbin opened a new pull request #2960: Assign each status type an constant explicitly

lingbin opened a new pull request #2960: Assign each status type an constant explicitly
URL: https://github.com/apache/incubator-doris/pull/2960
 
 
   The `TStatusCode` struct is used in all FEs and BEs. In order to be able to
   avoid errors when identifying status_codes in RPC when upgrading Doris
   (update and restart the servers one by one), we must ensure that each element
   always a fixed value.
   
   If each element is not explicitly assigned a constant, then the value of
   each element will be assigned from 0 in turn, which will need us to be 
   very careful when adding and removing elements, to avoid the same element on
   different machines to be recognized as a different value. i.e., new elements
   can only be added to the end, and only elements at the end can be deleted.
   Unfortunately, this implicit constraint is likely to be ignored by
   programmers when coding, especially those who are new to Doris.
   
   No functional change in this patch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] lingbin merged pull request #2960: Assign each status type an constant explicitly

Posted by GitBox <gi...@apache.org>.
lingbin merged pull request #2960: Assign each status type an constant explicitly
URL: https://github.com/apache/incubator-doris/pull/2960
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org