[GitHub] [daffodil] tuxji edited a comment on pull request #699: Update jdom2 to 2.0.6.1

[GitBox <gi...@apache.org>]

tuxji edited a comment on pull request #699:
URL: https://github.com/apache/daffodil/pull/699#issuecomment-988986834


   In <https://github.com/hunterhacker/jdom/issues/189#issuecomment-955682820>, the guy who built the jar said:
   
   > I built using Apache Ant 1.9.16 and Oracle JDK 1.7.0_75 that is the same version used to build v2.0.6 which is on Maven Central; then I compared the resulting JAR with the one of v2.0.6: there is only one class file changed: SAXBuilder.class; I also compared SAXBuilder.java source with master and there are no code differences (only some fixed typos on master).
   
   However, I downloaded both jdom2-2.0.6.jar and jdom2-2.0.6.1.jar from <https://repo1.maven.org/maven2/org/jdom/jdom2/2.0.6/jdom2-2.0.6.jar> and <https://repo1.maven.org/maven2/org/jdom/jdom2/2.0.6.1/jdom2-2.0.6.1.jar> respectively, unpacked them in separate empty directories with "jar xf", and compared them with "diff -rU2".  Every class is different and there are 12 new classes in 2.0.6.1.  Furthermore, 2.6.0.1 wasn't built with Oracle JDK 1.7.0_75, it was built with Oracle JDK 1.8.0_151.  I would have liked the new jar to have the same classes as the original jar (byte-for-byte) except for the class being fixed (SAXBuilder.class).  
   
   Let's wait for an official JDOM 2.0.6.1 announcement and both the JDOM website and GitHub repository to be updated before trusting the new jar.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org