[jira] [Commented] (CALCITE-2854) code gen error for UNARY_MINUS operator call with decimal type operands

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803143#comment-16803143 ] 

Julian Hyde commented on CALCITE-2854:
--------------------------------------

I see that the PR is working around CALCITE-2861. I've made that a dependency, and not commit until CALCITE-2861 has been fixed.

> code gen error for UNARY_MINUS operator call with decimal type operands
> -----------------------------------------------------------------------
>
>                 Key: CALCITE-2854
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2854
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.18.0
>            Reporter: Lai Zhou
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> case:
> {code:java}
>   @Test public void test() throws Exception {
>     final String cr = "create table t (a DECIMAL)";
>     final String se = "select -a as aa from t";
>     Connection c = connect();
>     Statement s = c.createStatement();
>     s.execute(cr);
>     s.executeQuery(se);
>   }
> {code}
> error msg: 
> {code:java}
> Caused by: org.codehaus.commons.compiler.CompileException: Line 21, Column 71: Object of type "java.math.BigDecimal" cannot be converted to a numeric type
> {code}
> {code:java}
> public Object current() {
> final java.math.BigDecimal current = inputEnumerator.current() == null ? (java.math.BigDecimal) null : org.apache.calcite.runtime.SqlFunctions.toBigDecimal(inputEnumerator.current());
> return current == null ? (java.math.BigDecimal) null : - current;
> }
> {code}
> `- current` is not right ,we'd better constructor a new BigDecimal object to to replace this code snippet，like 
> {code:java}
> return current == null ? (java.math.BigDecimal) null : SqlFunctions.negativeDecimal(current);
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)