You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/06 13:45:35 UTC
[GitHub] [incubator-tvm] roastduck opened a new pull request #5247: [TIR]
Fix lower_warp_memory
roastduck opened a new pull request #5247: [TIR] Fix lower_warp_memory
URL: https://github.com/apache/incubator-tvm/pull/5247
Fixing #5245
Just have a look at the change to `src/tir/transforms/lower_warp_memory.cc`, you will find the problem at a glance. I have to say this part was very poorly tested.
Changes:
- Fixed the function name.
- Added an end-to-end test on CUDA.
Since this is a compiler related issue, @tqchen, @ZihengJiang or @ajtulloch, can you make a review or suggest any other reviewers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen merged pull request #5247: [TIR] Fix
lower_warp_memory
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5247: [TIR] Fix lower_warp_memory
URL: https://github.com/apache/incubator-tvm/pull/5247
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #5247: [TIR] Fix
lower_warp_memory
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #5247: [TIR] Fix lower_warp_memory
URL: https://github.com/apache/incubator-tvm/pull/5247#issuecomment-609873561
Indeed we need better test coverage for this pass. Thanks @roastduck !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5247: [TIR] Fix
lower_warp_memory
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5247: [TIR] Fix lower_warp_memory
URL: https://github.com/apache/incubator-tvm/pull/5247#issuecomment-609873561
Thanks @roastduck !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #5247: [TIR] Fix
lower_warp_memory
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #5247: [TIR] Fix lower_warp_memory
URL: https://github.com/apache/incubator-tvm/pull/5247#issuecomment-609873561
Thanks @roastduck ! Indeed we need better test coverage for this pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services