You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Jukka Zitting <ju...@gmail.com> on 2010/05/17 10:24:04 UTC
Re: svn commit: r943816 [1/9] - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers:
./ log4j12-api/ log4j12-api/src/ log4j12-api/src/main/ log4j12-api/src/main/java/
log4j12-api/src/main/java/org/ log4j12-api/src/main/java/org/apache/ log4j12-
Hi,
As suggested by Sander Temme [1], how about using "svn propset
--revprop -r 943816 svn:log '...'" to update the commit message of
this revision? Having Ralph's extended summary included in the svn
history would be much better than just the current "First version"
message.
[1] http://jukkaz.wordpress.com/2010/05/14/commit-early-commit-often/#comment-9667
BR,
Jukka Zitting
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r943816 [1/9] - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers:
./ log4j12-api/ log4j12-api/src/ log4j12-api/src/main/ log4j12-api/src/main/java/
log4j12-api/src/main/java/org/ log4j12-api/src/main/java/org/apache/ log4j12-
Posted by Christian Grobmeier <gr...@gmail.com>.
As just replied on the private list, imho this is now clear, is it?
I also think its covered within Ralphs CLA which has been explained to
me in the e-mail Curt has sent to the baord.
Right?
On Tue, May 18, 2010 at 8:32 AM, Ralph Goers <ra...@dslextreme.com> wrote:
> In looking at the template again I really don't see how it applies. The
> section under copyright has "Identify name recorded for software grant: the
> name of the grant as record in the grants.txt document so that the grant can
> be easily identified". There is no software grant for this as it is covered
> under my ICLA.
> Ralph
>
>
> On May 17, 2010, at 7:06 PM, Curt Arnold wrote:
>
> On May 17, 2010, at 9:11 AM, Ralph Goers wrote:
>
>
> I haven't dug into it, but I think the submission may require IP clearance
> through the incubator (http://incubator.apache.org/ip-clearance/index.html).
> The sentence would appear to apply:
>
> Any code that was developed outside of the ASF SVN repository and our public
> mailing lists must be processed like this, even if the external developer is
> already an ASF committer.
>
> And the paragraph above that says "From time to time, an external codebase
> is brought into the ASF that is not a separate incubating project but still
> represents a substantial contribution that was not developed within the
> ASF's source control system and on our public mailing lists."
>
> All code developed at the ASF is developed off-list and then committed so by
> the logic of using only the message you quoted almost all code would have to
> go through the incubator unless the code was sent to the mailing list first.
> Obviously, that makes no sense. Taking that one sentence by itself would
> imply that when a new Appender is written and committed to Jira that it
> would need to go through the incubator as well.
>
> I've looked at the template. It is appears to be for code that "lived"
> outside of the ASF for some time, either as a separate project or was
> somehow visible to other people before being contributed. The code in
> question is not an "external codebase" because it was developed solely for
> the purpose of being committed to Log4j for experimentation and discussion.
> Whether it makes it into something that is ever released is for the
> community to determine.
>
> Ralph
>
>
> My take is that there is a poorly defined threshold of off-list-ness at
> which IP clearance is warranted like there is a threshold at which an ICLA
> is warranted. An ICLA is always desirable but there is a threshold which
> the implied grant in the ASL lets you sleep at night. Can bounce it off
> incubator@ to get a clarification of when it comes into play, but I don't
> think it is clear that it does not need one.
>
> Is there a revision history in a personal SVN, Git, etc? If so, could you
> dump it and attach it to a bug report?
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r943816 [1/9] - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers: ./ log4j12-api/ log4j12-api/src/ log4j12-api/src/main/ log4j12-api/src/main/java/ log4j12-api/src/main/java/org/ log4j12-api/src/main/java/org/apache/ log4j12-
Posted by Ralph Goers <ra...@dslextreme.com>.
In looking at the template again I really don't see how it applies. The section under copyright has "Identify name recorded for software grant: the name of the grant as record in the grants.txt document so that the grant can be easily identified". There is no software grant for this as it is covered under my ICLA.
Ralph
On May 17, 2010, at 7:06 PM, Curt Arnold wrote:
>
> On May 17, 2010, at 9:11 AM, Ralph Goers wrote:
>>
>>>
>>> I haven't dug into it, but I think the submission may require IP clearance through the incubator (http://incubator.apache.org/ip-clearance/index.html). The sentence would appear to apply:
>>>>
>>>> Any code that was developed outside of the ASF SVN repository and our public mailing lists must be processed like this, even if the external developer is already an ASF committer.
>>
>> And the paragraph above that says "From time to time, an external codebase is brought into the ASF that is not a separate incubating project but still represents a substantial contribution that was not developed within the ASF's source control system and on our public mailing lists."
>>
>> All code developed at the ASF is developed off-list and then committed so by the logic of using only the message you quoted almost all code would have to go through the incubator unless the code was sent to the mailing list first. Obviously, that makes no sense. Taking that one sentence by itself would imply that when a new Appender is written and committed to Jira that it would need to go through the incubator as well.
>>
>> I've looked at the template. It is appears to be for code that "lived" outside of the ASF for some time, either as a separate project or was somehow visible to other people before being contributed. The code in question is not an "external codebase" because it was developed solely for the purpose of being committed to Log4j for experimentation and discussion. Whether it makes it into something that is ever released is for the community to determine.
>>
>> Ralph
>>
>
> My take is that there is a poorly defined threshold of off-list-ness at which IP clearance is warranted like there is a threshold at which an ICLA is warranted. An ICLA is always desirable but there is a threshold which the implied grant in the ASL lets you sleep at night. Can bounce it off incubator@ to get a clarification of when it comes into play, but I don't think it is clear that it does not need one.
>
> Is there a revision history in a personal SVN, Git, etc? If so, could you dump it and attach it to a bug report?
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
Re: svn commit: r943816 [1/9] - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers: ./ log4j12-api/ log4j12-api/src/ log4j12-api/src/main/ log4j12-api/src/main/java/ log4j12-api/src/main/java/org/ log4j12-api/src/main/java/org/apache/ log4j12-
Posted by Ralph Goers <ra...@dslextreme.com>.
On May 17, 2010, at 7:06 PM, Curt Arnold wrote:
>
> On May 17, 2010, at 9:11 AM, Ralph Goers wrote:
>>
>>>
>>> I haven't dug into it, but I think the submission may require IP clearance through the incubator (http://incubator.apache.org/ip-clearance/index.html). The sentence would appear to apply:
>>>>
>>>> Any code that was developed outside of the ASF SVN repository and our public mailing lists must be processed like this, even if the external developer is already an ASF committer.
>>
>> And the paragraph above that says "From time to time, an external codebase is brought into the ASF that is not a separate incubating project but still represents a substantial contribution that was not developed within the ASF's source control system and on our public mailing lists."
>>
>> All code developed at the ASF is developed off-list and then committed so by the logic of using only the message you quoted almost all code would have to go through the incubator unless the code was sent to the mailing list first. Obviously, that makes no sense. Taking that one sentence by itself would imply that when a new Appender is written and committed to Jira that it would need to go through the incubator as well.
>>
>> I've looked at the template. It is appears to be for code that "lived" outside of the ASF for some time, either as a separate project or was somehow visible to other people before being contributed. The code in question is not an "external codebase" because it was developed solely for the purpose of being committed to Log4j for experimentation and discussion. Whether it makes it into something that is ever released is for the community to determine.
>>
>> Ralph
>>
>
> My take is that there is a poorly defined threshold of off-list-ness at which IP clearance is warranted like there is a threshold at which an ICLA is warranted. An ICLA is always desirable but there is a threshold which the implied grant in the ASL lets you sleep at night. Can bounce it off incubator@ to get a clarification of when it comes into play, but I don't think it is clear that it does not need one.
Actually, I don't think there is ever an implied grant:
a) a committer commits code they wrote - they have an ICLA on file.
b) someone posts a patch to Jira. The user checks the box granting a license to the ASF for the work.
c) a committer obtains permission from a third party to commit the work (this has been done many times in Maven and is actually how some projects enter the incubator - see http://wiki.apache.org/incubator/DeltacloudProposal for example).
d) a third party provides a software grant.
>
> Is there a revision history in a personal SVN, Git, etc? If so, could you dump it and attach it to a bug report?
No. This code was all developed on my Mac. The first commit off that box was here. That is why I don't believe that section applies. There are two java classes in the contribution that either I didn't write or weren't a modification of code already in Log4j SVN. The first, ResolverUtil was already under an Apache license and originated in Stripes but I got it from Struts. The second class is ParameterizedMessage which was written by Joern Huxhorn who developed it for Lillith. He explicitly gave me permission to commit it to Log4j under the Apache license so long as he is mentioned.
Ralph
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r943816 [1/9] - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers: ./ log4j12-api/ log4j12-api/src/ log4j12-api/src/main/ log4j12-api/src/main/java/ log4j12-api/src/main/java/org/ log4j12-api/src/main/java/org/apache/ log4j12-
Posted by Curt Arnold <ca...@apache.org>.
On May 17, 2010, at 9:11 AM, Ralph Goers wrote:
>
>>
>> I haven't dug into it, but I think the submission may require IP clearance through the incubator (http://incubator.apache.org/ip-clearance/index.html). The sentence would appear to apply:
>>>
>>> Any code that was developed outside of the ASF SVN repository and our public mailing lists must be processed like this, even if the external developer is already an ASF committer.
>
> And the paragraph above that says "From time to time, an external codebase is brought into the ASF that is not a separate incubating project but still represents a substantial contribution that was not developed within the ASF's source control system and on our public mailing lists."
>
> All code developed at the ASF is developed off-list and then committed so by the logic of using only the message you quoted almost all code would have to go through the incubator unless the code was sent to the mailing list first. Obviously, that makes no sense. Taking that one sentence by itself would imply that when a new Appender is written and committed to Jira that it would need to go through the incubator as well.
>
> I've looked at the template. It is appears to be for code that "lived" outside of the ASF for some time, either as a separate project or was somehow visible to other people before being contributed. The code in question is not an "external codebase" because it was developed solely for the purpose of being committed to Log4j for experimentation and discussion. Whether it makes it into something that is ever released is for the community to determine.
>
> Ralph
>
My take is that there is a poorly defined threshold of off-list-ness at which IP clearance is warranted like there is a threshold at which an ICLA is warranted. An ICLA is always desirable but there is a threshold which the implied grant in the ASL lets you sleep at night. Can bounce it off incubator@ to get a clarification of when it comes into play, but I don't think it is clear that it does not need one.
Is there a revision history in a personal SVN, Git, etc? If so, could you dump it and attach it to a bug report?
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r943816 [1/9] - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers: ./ log4j12-api/ log4j12-api/src/ log4j12-api/src/main/ log4j12-api/src/main/java/ log4j12-api/src/main/java/org/ log4j12-api/src/main/java/org/apache/ log4j12-
Posted by Ralph Goers <ra...@dslextreme.com>.
On May 17, 2010, at 6:42 AM, Curt Arnold wrote:
>
> On May 17, 2010, at 3:24 AM, Jukka Zitting wrote:
>
>> Hi,
>>
>> As suggested by Sander Temme [1], how about using "svn propset
>> --revprop -r 943816 svn:log '...'" to update the commit message of
>> this revision? Having Ralph's extended summary included in the svn
>> history would be much better than just the current "First version"
>> message.
>>
>> [1] http://jukkaz.wordpress.com/2010/05/14/commit-early-commit-often/#comment-9667
>>
>> BR,
>>
>> Jukka Zitting
>
> Good idea, there is nothing as fun as trying to track down an issue and you run into a monolithic commit of code many years ago with no history behind it.
I believe there might be a maximum length on a commit message but I'm not sure.
>
> I haven't dug into it, but I think the submission may require IP clearance through the incubator (http://incubator.apache.org/ip-clearance/index.html). The sentence would appear to apply:
>>
>> Any code that was developed outside of the ASF SVN repository and our public mailing lists must be processed like this, even if the external developer is already an ASF committer.
And the paragraph above that says "From time to time, an external codebase is brought into the ASF that is not a separate incubating project but still represents a substantial contribution that was not developed within the ASF's source control system and on our public mailing lists."
All code developed at the ASF is developed off-list and then committed so by the logic of using only the message you quoted almost all code would have to go through the incubator unless the code was sent to the mailing list first. Obviously, that makes no sense. Taking that one sentence by itself would imply that when a new Appender is written and committed to Jira that it would need to go through the incubator as well.
I've looked at the template. It is appears to be for code that "lived" outside of the ASF for some time, either as a separate project or was somehow visible to other people before being contributed. The code in question is not an "external codebase" because it was developed solely for the purpose of being committed to Log4j for experimentation and discussion. Whether it makes it into something that is ever released is for the community to determine.
Ralph
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r943816 [1/9] - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers: ./ log4j12-api/ log4j12-api/src/ log4j12-api/src/main/ log4j12-api/src/main/java/ log4j12-api/src/main/java/org/ log4j12-api/src/main/java/org/apache/ log4j12-
Posted by Curt Arnold <ca...@apache.org>.
On May 17, 2010, at 3:24 AM, Jukka Zitting wrote:
> Hi,
>
> As suggested by Sander Temme [1], how about using "svn propset
> --revprop -r 943816 svn:log '...'" to update the commit message of
> this revision? Having Ralph's extended summary included in the svn
> history would be much better than just the current "First version"
> message.
>
> [1] http://jukkaz.wordpress.com/2010/05/14/commit-early-commit-often/#comment-9667
>
> BR,
>
> Jukka Zitting
Good idea, there is nothing as fun as trying to track down an issue and you run into a monolithic commit of code many years ago with no history behind it.
I haven't dug into it, but I think the submission may require IP clearance through the incubator (http://incubator.apache.org/ip-clearance/index.html). The sentence would appear to apply:
>
> Any code that was developed outside of the ASF SVN repository and our public mailing lists must be processed like this, even if the external developer is already an ASF committer.
That might entail pulling this commit and bringing it back in. If available, I'd like to import the earlier revision history of the code.
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org