[jira] [Commented] (ZOOKEEPER-1887) C implementation of removeWatches

["Thawan Kooburat (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917820#comment-13917820 ] 

Thawan Kooburat commented on ZOOKEEPER-1887:
--------------------------------------------

This feature is a bit more complicated that what I have thought. I will try to spend more time understanding Java implementation so I can review this one more thoroughly. 

Here is some of comment on my first pass on the patch
- There is startServer() and stopserver() facility in TestClient.cc.  I wondering if you can use this to expand the test coverage for the feature especially for local=true. Since you can remove the watch even if you are in disconnected state
- In c-client a watch is represented by (watcher_fn, context) tuple or watcher_object_t internally.  To make the c-client has the equivalent functionality with Java client, we have to actually remove a watch based on (watcher_fn, context) tuple instead.  What do you think?
 

> C implementation of removeWatches
> ---------------------------------
>
>                 Key: ZOOKEEPER-1887
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1887
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: c client
>            Reporter: Raul Gutierrez Segales
>            Assignee: Raul Gutierrez Segales
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1887.patch, ZOOKEEPER-1887.patch
>
>
> This is equivalent for ZOOKEEPER-442's Java impl. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)