You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/02/27 20:39:39 UTC
Review Request 31555: LENS-362 : Skip estimating on driver in case of
rewrite errors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31555/
-----------------------------------------------------------
Review request for lens, Jaideep dhok and Rajat Khandelwal.
Bugs: LENS-362
https://issues.apache.org/jira/browse/LENS-362
Repository: lens
Description
-------
Changes include :
* Skip estimating on driver in case of rewrite errors
* Added unti tests
Diffs
-----
lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java 98c0b48
lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java 77b6545
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 88a6fee
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java d1e22ca
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b58ec76
Diff: https://reviews.apache.org/r/31555/diff/
Testing
-------
Verified the behavior on examples
Will update full test result
Thanks,
Amareshwari Sriramadasu
Re: Review Request 31555: LENS-362 : Skip estimating on driver in
case of rewrite errors
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31555/#review74575
-----------------------------------------------------------
Ship it!
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
<https://reviews.apache.org/r/31555/#comment121182>
The above function does null handling, but this one and the below one don't. Created https://issues.apache.org/jira/browse/LENS-367 for a deeper inspection. The diff looks fine as of now.
- Rajat Khandelwal
On Feb. 28, 2015, 1:13 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31555/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2015, 1:13 a.m.)
>
>
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
>
>
> Bugs: LENS-362
> https://issues.apache.org/jira/browse/LENS-362
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Skip estimating on driver in case of rewrite errors
> - Added unti tests
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java 98c0b48
> lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java 77b6545
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 88a6fee
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java d1e22ca
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b58ec76
>
> Diff: https://reviews.apache.org/r/31555/diff/
>
>
> Testing
> -------
>
> Verified the behavior on examples
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.116s]
> [INFO] Lens .............................................. SUCCESS [1.905s]
> [INFO] Lens API .......................................... SUCCESS [5.488s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.118s]
> [INFO] Lens Cube ......................................... SUCCESS [6:31.402s]
> [INFO] Lens DB storage ................................... SUCCESS [10.236s]
> [INFO] Lens Query Library ................................ SUCCESS [4.767s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.532s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [25.645s]
> [INFO] Lens Server ....................................... SUCCESS [4:31.741s]
> [INFO] Lens client ....................................... SUCCESS [20.952s]
> [INFO] Lens CLI .......................................... SUCCESS [1:40.784s]
> [INFO] Lens Examples ..................................... SUCCESS [0.921s]
> [INFO] Lens Distribution ................................. SUCCESS [9.534s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.851s]
> [INFO] Lens Regression ................................... SUCCESS [0.465s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:30.371s
> [INFO] Finished at: Fri Feb 27 19:42:10 UTC 2015
> [INFO] Final Memory: 99M/1003M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 31555: LENS-362 : Skip estimating on driver in
case of rewrite errors
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31555/
-----------------------------------------------------------
(Updated Feb. 27, 2015, 7:43 p.m.)
Review request for lens, Jaideep dhok and Rajat Khandelwal.
Bugs: LENS-362
https://issues.apache.org/jira/browse/LENS-362
Repository: lens
Description (updated)
-------
Changes include :
- Skip estimating on driver in case of rewrite errors
- Added unti tests
Diffs
-----
lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java 98c0b48
lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java 77b6545
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 88a6fee
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java d1e22ca
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b58ec76
Diff: https://reviews.apache.org/r/31555/diff/
Testing (updated)
-------
Verified the behavior on examples
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.116s]
[INFO] Lens .............................................. SUCCESS [1.905s]
[INFO] Lens API .......................................... SUCCESS [5.488s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.118s]
[INFO] Lens Cube ......................................... SUCCESS [6:31.402s]
[INFO] Lens DB storage ................................... SUCCESS [10.236s]
[INFO] Lens Query Library ................................ SUCCESS [4.767s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:33.532s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [25.645s]
[INFO] Lens Server ....................................... SUCCESS [4:31.741s]
[INFO] Lens client ....................................... SUCCESS [20.952s]
[INFO] Lens CLI .......................................... SUCCESS [1:40.784s]
[INFO] Lens Examples ..................................... SUCCESS [0.921s]
[INFO] Lens Distribution ................................. SUCCESS [9.534s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.851s]
[INFO] Lens Regression ................................... SUCCESS [0.465s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:30.371s
[INFO] Finished at: Fri Feb 27 19:42:10 UTC 2015
[INFO] Final Memory: 99M/1003M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu