You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by se...@apache.org on 2014/05/27 02:29:38 UTC
svn commit: r1597678 - in /jmeter/trunk:
src/components/org/apache/jmeter/visualizers/
src/protocol/http/org/apache/jmeter/protocol/http/gui/ xdocs/
Author: sebb
Date: Tue May 27 00:29:38 2014
New Revision: 1597678
URL: http://svn.apache.org/r1597678
Log:
Jmeter silently fails to save results
Bugzilla Id: 56419
Modified:
jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatGraphVisualizer.java
jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatVisualizer.java
jmeter/trunk/src/components/org/apache/jmeter/visualizers/SummaryReport.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/AuthPanel.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/HeaderPanel.java
jmeter/trunk/xdocs/changes.xml
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatGraphVisualizer.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatGraphVisualizer.java?rev=1597678&r1=1597677&r2=1597678&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatGraphVisualizer.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatGraphVisualizer.java Tue May 27 00:29:38 2014
@@ -569,9 +569,9 @@ public class StatGraphVisualizer extends
writer = new FileWriter(chooser.getSelectedFile()); // TODO Charset ?
CSVSaveService.saveCSVStats(getAllTableData(),writer,saveHeaders.isSelected() ? COLUMNS : null);
} catch (FileNotFoundException e) {
- log.warn(e.getMessage());
+ JMeterUtils.reportErrorToUser(e.getMessage(), "Error saving data");
} catch (IOException e) {
- log.warn(e.getMessage());
+ JMeterUtils.reportErrorToUser(e.getMessage(), "Error saving data");
} finally {
JOrphanUtils.closeQuietly(writer);
}
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatVisualizer.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatVisualizer.java?rev=1597678&r1=1597677&r2=1597678&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatVisualizer.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatVisualizer.java Tue May 27 00:29:38 2014
@@ -38,8 +38,6 @@ import javax.swing.JTable;
import javax.swing.border.Border;
import javax.swing.border.EmptyBorder;
import javax.swing.table.TableCellRenderer;
-//import javax.swing.table.AbstractTableModel;
-//import javax.swing.table.TableModel;
import org.apache.jmeter.gui.util.FileDialoger;
import org.apache.jmeter.gui.util.HeaderAsPropertyRenderer;
@@ -53,10 +51,8 @@ import org.apache.jorphan.gui.NumberRend
import org.apache.jorphan.gui.ObjectTableModel;
import org.apache.jorphan.gui.RateRenderer;
import org.apache.jorphan.gui.RendererUtils;
-import org.apache.jorphan.logging.LoggingManager;
import org.apache.jorphan.reflect.Functor;
import org.apache.jorphan.util.JOrphanUtils;
-import org.apache.log.Logger;
/**
* Aggregrate Table-Based Reporting Visualizer for JMeter. Props to the people
@@ -69,8 +65,6 @@ public class StatVisualizer extends Abst
private static final long serialVersionUID = 240L;
- private static final Logger log = LoggingManager.getLoggerForClass();
-
private static final String USE_GROUP_NAME = "useGroupName"; //$NON-NLS-1$
private static final String SAVE_HEADERS = "saveHeaders"; //$NON-NLS-1$
@@ -265,9 +259,9 @@ public class StatVisualizer extends Abst
writer = new FileWriter(chooser.getSelectedFile()); // TODO Charset ?
CSVSaveService.saveCSVStats(model,writer, saveHeaders.isSelected());
} catch (FileNotFoundException e) {
- log.warn(e.getMessage());
+ JMeterUtils.reportErrorToUser(e.getMessage(), "Error saving data");
} catch (IOException e) {
- log.warn(e.getMessage());
+ JMeterUtils.reportErrorToUser(e.getMessage(), "Error saving data");
} finally {
JOrphanUtils.closeQuietly(writer);
}
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/SummaryReport.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SummaryReport.java?rev=1597678&r1=1597677&r2=1597678&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/SummaryReport.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/SummaryReport.java Tue May 27 00:29:38 2014
@@ -52,10 +52,8 @@ import org.apache.jorphan.gui.NumberRend
import org.apache.jorphan.gui.ObjectTableModel;
import org.apache.jorphan.gui.RateRenderer;
import org.apache.jorphan.gui.RendererUtils;
-import org.apache.jorphan.logging.LoggingManager;
import org.apache.jorphan.reflect.Functor;
import org.apache.jorphan.util.JOrphanUtils;
-import org.apache.log.Logger;
/**
* Simpler (lower memory) version of Aggregate Report (StatVisualizer).
@@ -65,8 +63,6 @@ public class SummaryReport extends Abstr
private static final long serialVersionUID = 240L;
- private static final Logger log = LoggingManager.getLoggerForClass();
-
private static final String USE_GROUP_NAME = "useGroupName"; //$NON-NLS-1$
private static final String SAVE_HEADERS = "saveHeaders"; //$NON-NLS-1$
@@ -260,9 +256,9 @@ public class SummaryReport extends Abstr
writer = new FileWriter(chooser.getSelectedFile());
CSVSaveService.saveCSVStats(model,writer, saveHeaders.isSelected());
} catch (FileNotFoundException e) {
- log.warn(e.getMessage());
+ JMeterUtils.reportErrorToUser(e.getMessage(), "Error saving data");
} catch (IOException e) {
- log.warn(e.getMessage());
+ JMeterUtils.reportErrorToUser(e.getMessage(), "Error saving data");
} finally {
JOrphanUtils.closeQuietly(writer);
}
Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/AuthPanel.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/AuthPanel.java?rev=1597678&r1=1597677&r2=1597678&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/AuthPanel.java (original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/AuthPanel.java Tue May 27 00:29:38 2014
@@ -261,7 +261,7 @@ public class AuthPanel extends AbstractC
tableModel.manager.save(chooser.getSelectedFile().getAbsolutePath());
}
} catch (IOException ex) {
- log.error("", ex);
+ JMeterUtils.reportErrorToUser(ex.getMessage(), "Error saving auth data");
}
}
}
Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java?rev=1597678&r1=1597677&r2=1597678&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java (original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java Tue May 27 00:29:38 2014
@@ -232,7 +232,7 @@ public class CookiePanel extends Abstrac
((CookieManager) createTestElement()).save(chooser.getSelectedFile().getAbsolutePath());
}
} catch (IOException ex) {
- log.error("", ex);
+ JMeterUtils.reportErrorToUser(ex.getMessage(), "Error saving cookies");
}
}
}
Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/HeaderPanel.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/HeaderPanel.java?rev=1597678&r1=1597677&r2=1597678&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/HeaderPanel.java (original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/HeaderPanel.java Tue May 27 00:29:38 2014
@@ -223,7 +223,7 @@ public class HeaderPanel extends Abstrac
headerManager.save(chooser.getSelectedFile().getAbsolutePath());
}
} catch (IOException ex) {
- log.error("Could not save headers", ex);
+ JMeterUtils.reportErrorToUser(ex.getMessage(), "Error saving headers");
}
} else if (action.equals(ADD_FROM_CLIPBOARD)) {
addFromClipboard();
Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1597678&r1=1597677&r2=1597678&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml (original)
+++ jmeter/trunk/xdocs/changes.xml Tue May 27 00:29:38 2014
@@ -170,6 +170,7 @@ A workaround is to use a Java 7 update 4
<li><bugzilla>56080</bugzilla> - Conversion error com.thoughtworks.xstream.converters.ConversionException with Java 8 Early Access Build</li>
<li><bugzilla>56182</bugzilla> - Can't trigger bsh script using bshclient.jar; socket is closed unexpectedly </li>
<li><bugzilla>56360</bugzilla> - HashTree and ListedHashTree fail to compile with Java 8</li>
+<li><bugzilla>56419</bugzilla> - Jmeter silently fails to save results</li>
</ul>
<!-- =================== Improvements =================== -->