[GitHub] [incubator-druid] mcbrewster commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view

[GitBox <gi...@apache.org>]

mcbrewster commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view
URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r285804403
 
 

 ##########
 File path: web-console/src/views/tasks-view.tsx
 ##########
 @@ -508,18 +518,24 @@ ORDER BY "rank" DESC, "created_time" DESC`);
     </>;
   }
 
-  // --------------------------------------
-
-  private getTaskActions(id: string, status: string): BasicAction[] {
-    if (status !== 'RUNNING' && status !== 'WAITING' && status !== 'PENDING') return [];
-    return [
-      {
-        icon: IconNames.CROSS,
+  private getTaskActions(id: string, status: string, type: string): BasicAction[] {
+    const actions = [];
+    if (type === 'index' || type === 'index_parallel') {
+      actions.push({
+        title: 'Open in json spec editor',
+        intent: Intent.DANGER,
 
 Review comment:
   it shouldn't, I've removed it now

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org