You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sc...@apache.org on 2016/02/06 22:09:26 UTC

[2/2] maven-integration-testing git commit: [MNG-5783] cobertura-maven-plugin:instrument failing NoClassDefFoundError: org/slf4j/LoggerFactory

[MNG-5783] cobertura-maven-plugin:instrument failing NoClassDefFoundError: org/slf4j/LoggerFactory

o Updated to only test for plugin dependencies also part of Maven
  core to not getting filtered out. The list of plugin artifacts may
  differ using different Maven versions.


Project: http://git-wip-us.apache.org/repos/asf/maven-integration-testing/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven-integration-testing/commit/6de9b84c
Tree: http://git-wip-us.apache.org/repos/asf/maven-integration-testing/tree/6de9b84c
Diff: http://git-wip-us.apache.org/repos/asf/maven-integration-testing/diff/6de9b84c

Branch: refs/heads/master
Commit: 6de9b84c803a1a158dfe1183813ae13438267da9
Parents: bb1c292
Author: Christian Schulte <sc...@apache.org>
Authored: Sat Feb 6 20:57:16 2016 +0100
Committer: Christian Schulte <sc...@apache.org>
Committed: Sat Feb 6 21:09:03 2016 +0100

----------------------------------------------------------------------
 ...MavenITmng5783PluginDependencyFiltering.java | 23 +++++++++++++-------
 1 file changed, 15 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/maven-integration-testing/blob/6de9b84c/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5783PluginDependencyFiltering.java
----------------------------------------------------------------------
diff --git a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5783PluginDependencyFiltering.java b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5783PluginDependencyFiltering.java
index ec5242c..d8db654 100644
--- a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5783PluginDependencyFiltering.java
+++ b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5783PluginDependencyFiltering.java
@@ -28,13 +28,20 @@ public class MavenITmng5783PluginDependencyFiltering
         verifier.verifyErrorFreeLog();
         verifier.resetStreams();
 
-        // Note that plugin dependencies always include plugin itself and plexus-utils
-
-        List<String> dependencies = verifier.loadLines( "target/dependencies.txt", "UTF-8" );
-        assertEquals( 3, dependencies.size() );
-        assertEquals( "mng-5783-plugin-dependency-filtering:mng-5783-plugin-dependency-filtering-plugin:maven-plugin:0.1",
-                      dependencies.get( 0 ) );
-        assertEquals( "org.slf4j:slf4j-api:jar:1.7.5", dependencies.get( 1 ) );
-        assertEquals( "org.codehaus.plexus:plexus-utils:jar:1.1", dependencies.get( 2 ) );
+        final List<String> dependencies = verifier.loadLines( "target/dependencies.txt", "UTF-8" );
+        assertTrue( contains( dependencies, "org.slf4j:slf4j-api:jar:1.7.5" ) );
+    }
+
+    private static boolean contains( final List<String> lines, final String pattern )
+    {
+        for ( int i = 0, l0 = lines.size(); i < l0; i++ )
+        {
+            if ( lines.get( i ).contains( pattern ) )
+            {
+                return true;
+            }
+        }
+
+        return false;
     }
 }