[jira] [Commented] (TINKERPOP-2041) Text Predicates

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634084#comment-16634084 ] 

ASF GitHub Bot commented on TINKERPOP-2041:
-------------------------------------------

GitHub user dkuppitz opened a pull request:

    https://github.com/apache/tinkerpop/pull/944

    TINKERPOP-2041 Text Predicates

    https://issues.apache.org/jira/browse/TINKERPOP-2041
    
    This PR adds a few text predicates (`TP`):
    
    * `startsWith`
    * `endsWith`
    * `contains`
    
    By the contract definition, every predicate needs an opposite predicate, hence I also added the following:
    
    * `startsNotWith`
    * `endsNotWith`
    * `absent`
    
    However, I don't like the naming too much. If anybody has better suggestions, I'm all ears.
    
    `docker/build.sh -t -i -n` passed.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-2041

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/944.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #944
    
----
commit 242a9e399f4c73c02068dda73cc3bd52eeb7e00f
Author: Daniel Kuppitz <da...@...>
Date:   2018-09-26T22:44:35Z

    TINKERPOP-2041 Implemented text predicates

commit 1a0ca3ade124dcc34761085ee58db2f7e68e3d06
Author: Stephen Mallette <sp...@...>
Date:   2018-09-27T20:33:26Z

    TINKERPOP-2041 Fixed gremlin-javascript serializers for TP

commit 441cf6aa4769805215045e460e1daad8b46a1cfb
Author: Stephen Mallette <sp...@...>
Date:   2018-09-28T12:27:25Z

    TINKERPOP-2041 Fixed .NET tests around TP predicates

----


> Text Predicates
> ---------------
>
>                 Key: TINKERPOP-2041
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2041
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.4.0
>            Reporter: Daniel Kuppitz
>            Assignee: Daniel Kuppitz
>            Priority: Major
>
> Provide these simple text predicates:
>  * {{startsWith}}
>  * {{endsWith}}
>  * {{contains}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)